From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH 15/15] block: Allow overriding backing.file.filename
Date: Fri, 12 Apr 2013 22:48:08 +0200 [thread overview]
Message-ID: <1365799688-19918-16-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1365799688-19918-1-git-send-email-kwolf@redhat.com>
If a filename is passed in the driver-specific options from the command
line, the backing file path from the image is ignored now.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/block.c b/block.c
index c2d1d2d..3a45c2a 100644
--- a/block.c
+++ b/block.c
@@ -889,7 +889,9 @@ int bdrv_open_backing_file(BlockDriverState *bs, QDict *options)
}
bs->open_flags &= ~BDRV_O_NO_BACKING;
- if (bs->backing_file[0] == '\0' && qdict_size(options) == 0) {
+ if (qdict_haskey(options, "file.filename")) {
+ backing_filename[0] = '\0';
+ } else if (bs->backing_file[0] == '\0' && qdict_size(options) == 0) {
QDECREF(options);
return 0;
}
--
1.8.1.4
next prev parent reply other threads:[~2013-04-12 20:48 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 20:47 [Qemu-devel] [PATCH 00/15] block: Overriding the backing file with -drive Kevin Wolf
2013-04-12 20:47 ` [Qemu-devel] [PATCH 01/15] block: Fail gracefully when using a format driver on protocol level Kevin Wolf
2013-04-12 22:50 ` Eric Blake
2013-04-15 9:06 ` Kevin Wolf
2013-04-15 12:02 ` Markus Armbruster
2013-04-12 20:47 ` [Qemu-devel] [PATCH 02/15] block: Add driver-specific options for backing files Kevin Wolf
2013-04-15 17:38 ` Eric Blake
2013-04-12 20:47 ` [Qemu-devel] [PATCH 03/15] block: Enable filename option Kevin Wolf
2013-04-15 17:43 ` Eric Blake
2013-04-12 20:47 ` [Qemu-devel] [PATCH 04/15] raw-posix: Use bdrv_open options instead of filename Kevin Wolf
2013-04-15 17:52 ` Eric Blake
2013-04-12 20:47 ` [Qemu-devel] [PATCH 05/15] raw-win32: " Kevin Wolf
2013-04-15 19:16 ` Eric Blake
2013-04-12 20:47 ` [Qemu-devel] [PATCH 06/15] blkdebug: " Kevin Wolf
2013-04-15 19:43 ` Eric Blake
2013-04-12 20:48 ` [Qemu-devel] [PATCH 07/15] blkverify: " Kevin Wolf
2013-04-15 19:47 ` Eric Blake
2013-04-12 20:48 ` [Qemu-devel] [PATCH 08/15] curl: " Kevin Wolf
2013-04-15 19:57 ` Eric Blake
2013-04-12 20:48 ` [Qemu-devel] [PATCH 09/15] gluster: " Kevin Wolf
2013-04-15 20:07 ` Eric Blake
2013-04-12 20:48 ` [Qemu-devel] [PATCH 10/15] iscsi: " Kevin Wolf
2013-04-15 20:26 ` Eric Blake
2013-04-12 20:48 ` [Qemu-devel] [PATCH 11/15] rbd: " Kevin Wolf
2013-04-15 20:27 ` Eric Blake
2013-04-12 20:48 ` [Qemu-devel] [PATCH 12/15] sheepdog: " Kevin Wolf
2013-04-15 20:29 ` Eric Blake
2013-04-12 20:48 ` [Qemu-devel] [PATCH 13/15] vvfat: " Kevin Wolf
2013-04-15 20:44 ` Eric Blake
2013-04-12 20:48 ` [Qemu-devel] [PATCH 14/15] block: Remove filename parameter from .bdrv_file_open() Kevin Wolf
2013-04-15 20:47 ` Eric Blake
2013-04-22 9:41 ` [Qemu-devel] [PATCH v2 " Kevin Wolf
2013-04-12 20:48 ` Kevin Wolf [this message]
2013-04-15 21:03 ` [Qemu-devel] [PATCH 15/15] block: Allow overriding backing.file.filename Eric Blake
2013-04-18 11:42 ` [Qemu-devel] [PATCH 00/15] block: Overriding the backing file with -drive Stefan Hajnoczi
2013-04-18 13:34 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365799688-19918-16-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).