qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Alexey Kardashevskiy <aik@ozlabs.ru>,
	Blue Swirl <blauwirbel@gmail.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls
Date: Mon, 15 Apr 2013 12:31:13 +1000	[thread overview]
Message-ID: <1365993073-4659-1-git-send-email-aik@ozlabs.ru> (raw)

The assert.h header file from Fedora18 does not have #ifdef-#endif
brackets around __assertXXXX function so it cannot compile with
the -Wredundant-decls switch on.

Some Linux distributions (such as Debian Wheezy) still do have those
brackets arounb __assertXXXX functions (#ifndef _ASSERT_H_DECLS) but
the version of assert.h on http://sourceware.org/git/?p=glibc.git does not
so we should not be using -Wredundant-decls.

The patch removes it.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 include/ui/qemu-pixman.h |    6 ------
 1 file changed, 6 deletions(-)

diff --git a/include/ui/qemu-pixman.h b/include/ui/qemu-pixman.h
index b032f52..6f473f9 100644
--- a/include/ui/qemu-pixman.h
+++ b/include/ui/qemu-pixman.h
@@ -7,13 +7,7 @@
 #define QEMU_PIXMAN_H
 
 /* pixman-0.16.0 headers have a redundant declaration */
-#ifdef CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE
-#pragma GCC diagnostic ignored "-Wredundant-decls"
-#endif
 #include <pixman.h>
-#ifdef CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE
-#pragma GCC diagnostic error "-Wredundant-decls"
-#endif
 
 #include "qemu/typedefs.h"
 
-- 
1.7.10.4

             reply	other threads:[~2013-04-15  2:31 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-15  2:31 Alexey Kardashevskiy [this message]
2013-04-15  7:08 ` [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls Markus Armbruster
2013-04-15  7:12   ` Alexey Kardashevskiy
2013-04-15  8:23     ` Markus Armbruster
2013-04-15  9:50       ` Alexey Kardashevskiy
2013-04-15 10:01         ` Peter Maydell
2013-04-15 10:40           ` Peter Maydell
2013-04-15 10:52           ` Alexey Kardashevskiy
2013-04-15 11:00             ` Peter Maydell
2013-04-15 11:08               ` Alexey Kardashevskiy
2013-04-15 11:14                 ` Peter Maydell
2013-04-15 11:20                   ` Alexey Kardashevskiy
2013-04-15 12:57             ` Markus Armbruster
2013-04-15 13:03               ` Alexey Kardashevskiy
2013-04-15 15:55                 ` Markus Armbruster
2013-04-15 22:48                   ` Alexey Kardashevskiy
2013-04-16  3:16                     ` Alexey Kardashevskiy
2013-04-16  7:57                       ` Markus Armbruster
2013-04-16  9:22                         ` Paolo Bonzini
2013-04-16 10:29                           ` Markus Armbruster
2013-04-16 10:54                           ` Alexey Kardashevskiy
2013-04-16 11:12                             ` Paolo Bonzini
2013-04-16 11:52                               ` Markus Armbruster
2013-04-16  9:00                     ` Markus Armbruster
2013-04-16 10:54                       ` Alexey Kardashevskiy
2013-04-16 11:51                       ` Kevin Wolf
2013-04-16 12:12                         ` Markus Armbruster
2013-04-15  7:18 ` Peter Maydell
2013-04-15  7:26   ` Alexey Kardashevskiy
2013-04-15  7:30     ` Peter Maydell
2013-04-15  7:45       ` Alexey Kardashevskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365993073-4659-1-git-send-email-aik@ozlabs.ru \
    --to=aik@ozlabs.ru \
    --cc=blauwirbel@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=kraxel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).