qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Nick Thomas <nick@bytemark.co.uk>
Subject: [Qemu-devel] [PATCH 3/3] nbd: set TCP_NODELAY
Date: Mon, 15 Apr 2013 16:14:48 +0200	[thread overview]
Message-ID: <1366035288-15840-4-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1366035288-15840-1-git-send-email-stefanha@redhat.com>

Disable the Nagle algorithm to reduce latency.  Note this means we must
also use TCP_CORK when sending header followed by payload to avoid
fragmenting lots of little packets.  The previous patch took care of
that.

Suggested-by: Nick Thomas <nick@bytemark.co.uk>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 block/nbd.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/block/nbd.c b/block/nbd.c
index 485bbf0..d9dc454 100644
--- a/block/nbd.c
+++ b/block/nbd.c
@@ -406,6 +406,9 @@ static int nbd_establish_connection(BlockDriverState *bs)
         sock = unix_socket_outgoing(qemu_opt_get(s->socket_opts, "path"));
     } else {
         sock = tcp_socket_outgoing_opts(s->socket_opts);
+        if (sock >= 0) {
+            socket_set_nodelay(sock);
+        }
     }
 
     /* Failed to establish connection */
-- 
1.8.1.4

  parent reply	other threads:[~2013-04-15 14:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-15 14:14 [Qemu-devel] [PATCH 0/3] nbd: use TCP_NODELAY Stefan Hajnoczi
2013-04-15 14:14 ` [Qemu-devel] [PATCH 1/3] nbd: unlock mutex in nbd_co_send_request() error path Stefan Hajnoczi
2013-04-15 14:14 ` [Qemu-devel] [PATCH 2/3] nbd: use TCP_CORK in nbd_co_send_request() Stefan Hajnoczi
2013-04-15 14:14 ` Stefan Hajnoczi [this message]
2013-04-15 14:28 ` [Qemu-devel] [PATCH 0/3] nbd: use TCP_NODELAY Nicholas Thomas
2013-04-15 14:33 ` Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2013-04-19 14:30 [Qemu-devel] [PULL 0/3] NBD changes for 2013-04-19 Paolo Bonzini
2013-04-19 14:30 ` [Qemu-devel] [PATCH 3/3] nbd: set TCP_NODELAY Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366035288-15840-4-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=nick@bytemark.co.uk \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).