qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
	Ilkka Tengvall <ilkka.tengvall@cybercom.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 0/4] qemu-img: support compression regardless of cluster size
Date: Mon, 15 Apr 2013 17:17:30 +0200	[thread overview]
Message-ID: <1366039054-32536-1-git-send-email-stefanha@redhat.com> (raw)

It was hard to find a short email subject line.  Anyway, the problem is that
qemu-img convert -c fails with the following error message if the input image
length is not a multiple of the output cluster size:

  qemu-img: error while compressing sector 0: Input/output error

Ilkka Tengvall <ilkka.tengvall@cybercom.com> reported the failure.  kwolf and
eblake suggested a fix which this patch series implements.

qemu-img convert -c succeeds with these patches applied.

The final patch adds qemu-iotests case 053 to protect against regressions.

Stefan Hajnoczi (4):
  qcow2: allow sub-cluster compressed write to last cluster
  qcow: allow sub-cluster compressed write to last cluster
  qemu-img: do not zero-pad the compressed write buffer
  qemu-iotests: add 053 unaligned compressed image size test

 block/qcow.c               | 17 +++++++++++--
 block/qcow2.c              | 17 +++++++++++--
 qemu-img.c                 |  8 ++----
 tests/qemu-iotests/053     | 63 ++++++++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/053.out | 10 ++++++++
 tests/qemu-iotests/group   |  1 +
 6 files changed, 106 insertions(+), 10 deletions(-)
 create mode 100755 tests/qemu-iotests/053
 create mode 100644 tests/qemu-iotests/053.out

-- 
1.8.1.4

             reply	other threads:[~2013-04-15 15:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-15 15:17 Stefan Hajnoczi [this message]
2013-04-15 15:17 ` [Qemu-devel] [PATCH 1/4] qcow2: allow sub-cluster compressed write to last cluster Stefan Hajnoczi
2013-04-15 15:17 ` [Qemu-devel] [PATCH 2/4] qcow: " Stefan Hajnoczi
2013-04-15 15:17 ` [Qemu-devel] [PATCH 3/4] qemu-img: do not zero-pad the compressed write buffer Stefan Hajnoczi
2013-04-15 15:17 ` [Qemu-devel] [PATCH 4/4] qemu-iotests: add 053 unaligned compressed image size test Stefan Hajnoczi
2013-04-15 15:38   ` Eric Blake
2013-04-16  8:36     ` Stefan Hajnoczi
2013-04-16  8:53       ` Kevin Wolf
2013-04-16  9:00 ` [Qemu-devel] [PATCH 0/4] qemu-img: support compression regardless of cluster size Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366039054-32536-1-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=famz@redhat.com \
    --cc=ilkka.tengvall@cybercom.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).