From: Alex Williamson <alex.williamson@redhat.com>
To: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] pci-assign: remove the duplicate function name in debug message
Date: Mon, 15 Apr 2013 12:39:27 -0600 [thread overview]
Message-ID: <1366051167.2918.166.camel@bling.home> (raw)
In-Reply-To: <1365749179-6069-1-git-send-email-gaowanlong@cn.fujitsu.com>
On Fri, 2013-04-12 at 14:46 +0800, Wanlong Gao wrote:
> While DEBUG() already includes the function name.
>
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> ---
> hw/i386/kvm/pci-assign.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Acked-by: Alex Williamson <alex.williamson@redhat.com>
>
> diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
> index c1e08ec..6afb82e 100644
> --- a/hw/i386/kvm/pci-assign.c
> +++ b/hw/i386/kvm/pci-assign.c
> @@ -226,7 +226,7 @@ static uint32_t slow_bar_readb(void *opaque, hwaddr addr)
> uint32_t r;
>
> r = *in;
> - DEBUG("slow_bar_readl addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
>
> return r;
> }
> @@ -238,7 +238,7 @@ static uint32_t slow_bar_readw(void *opaque, hwaddr addr)
> uint32_t r;
>
> r = *in;
> - DEBUG("slow_bar_readl addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
>
> return r;
> }
> @@ -250,7 +250,7 @@ static uint32_t slow_bar_readl(void *opaque, hwaddr addr)
> uint32_t r;
>
> r = *in;
> - DEBUG("slow_bar_readl addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
>
> return r;
> }
> @@ -260,7 +260,7 @@ static void slow_bar_writeb(void *opaque, hwaddr addr, uint32_t val)
> AssignedDevRegion *d = opaque;
> uint8_t *out = d->u.r_virtbase + addr;
>
> - DEBUG("slow_bar_writeb addr=0x" TARGET_FMT_plx " val=0x%02x\n", addr, val);
> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%02x\n", addr, val);
> *out = val;
> }
>
> @@ -269,7 +269,7 @@ static void slow_bar_writew(void *opaque, hwaddr addr, uint32_t val)
> AssignedDevRegion *d = opaque;
> uint16_t *out = (uint16_t *)(d->u.r_virtbase + addr);
>
> - DEBUG("slow_bar_writew addr=0x" TARGET_FMT_plx " val=0x%04x\n", addr, val);
> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%04x\n", addr, val);
> *out = val;
> }
>
> @@ -278,7 +278,7 @@ static void slow_bar_writel(void *opaque, hwaddr addr, uint32_t val)
> AssignedDevRegion *d = opaque;
> uint32_t *out = (uint32_t *)(d->u.r_virtbase + addr);
>
> - DEBUG("slow_bar_writel addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, val);
> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, val);
> *out = val;
> }
>
next prev parent reply other threads:[~2013-04-15 18:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 6:46 [Qemu-devel] [PATCH] pci-assign: remove the duplicate function name in debug message Wanlong Gao
2013-04-15 18:39 ` Alex Williamson [this message]
2013-05-28 2:25 ` Wanlong Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366051167.2918.166.camel@bling.home \
--to=alex.williamson@redhat.com \
--cc=gaowanlong@cn.fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).