From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URoJX-0001yE-Jo for qemu-devel@nongnu.org; Mon, 15 Apr 2013 14:39:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URoJW-0000e4-Dc for qemu-devel@nongnu.org; Mon, 15 Apr 2013 14:39:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10329) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URoJW-0000dh-5f for qemu-devel@nongnu.org; Mon, 15 Apr 2013 14:39:38 -0400 Message-ID: <1366051167.2918.166.camel@bling.home> From: Alex Williamson Date: Mon, 15 Apr 2013 12:39:27 -0600 In-Reply-To: <1365749179-6069-1-git-send-email-gaowanlong@cn.fujitsu.com> References: <1365749179-6069-1-git-send-email-gaowanlong@cn.fujitsu.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] pci-assign: remove the duplicate function name in debug message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wanlong Gao Cc: pbonzini@redhat.com, qemu-devel@nongnu.org On Fri, 2013-04-12 at 14:46 +0800, Wanlong Gao wrote: > While DEBUG() already includes the function name. > > Signed-off-by: Wanlong Gao > --- > hw/i386/kvm/pci-assign.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) Acked-by: Alex Williamson > > diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c > index c1e08ec..6afb82e 100644 > --- a/hw/i386/kvm/pci-assign.c > +++ b/hw/i386/kvm/pci-assign.c > @@ -226,7 +226,7 @@ static uint32_t slow_bar_readb(void *opaque, hwaddr addr) > uint32_t r; > > r = *in; > - DEBUG("slow_bar_readl addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r); > + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r); > > return r; > } > @@ -238,7 +238,7 @@ static uint32_t slow_bar_readw(void *opaque, hwaddr addr) > uint32_t r; > > r = *in; > - DEBUG("slow_bar_readl addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r); > + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r); > > return r; > } > @@ -250,7 +250,7 @@ static uint32_t slow_bar_readl(void *opaque, hwaddr addr) > uint32_t r; > > r = *in; > - DEBUG("slow_bar_readl addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r); > + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r); > > return r; > } > @@ -260,7 +260,7 @@ static void slow_bar_writeb(void *opaque, hwaddr addr, uint32_t val) > AssignedDevRegion *d = opaque; > uint8_t *out = d->u.r_virtbase + addr; > > - DEBUG("slow_bar_writeb addr=0x" TARGET_FMT_plx " val=0x%02x\n", addr, val); > + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%02x\n", addr, val); > *out = val; > } > > @@ -269,7 +269,7 @@ static void slow_bar_writew(void *opaque, hwaddr addr, uint32_t val) > AssignedDevRegion *d = opaque; > uint16_t *out = (uint16_t *)(d->u.r_virtbase + addr); > > - DEBUG("slow_bar_writew addr=0x" TARGET_FMT_plx " val=0x%04x\n", addr, val); > + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%04x\n", addr, val); > *out = val; > } > > @@ -278,7 +278,7 @@ static void slow_bar_writel(void *opaque, hwaddr addr, uint32_t val) > AssignedDevRegion *d = opaque; > uint32_t *out = (uint32_t *)(d->u.r_virtbase + addr); > > - DEBUG("slow_bar_writel addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, val); > + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, val); > *out = val; > } >