qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: av1474@comtv.ru, aurelien@aurel32.net
Subject: [Qemu-devel] [PATCH v5 26/33] tcg-ppc64: Cleanup i32 constants to tcg_out_cmp
Date: Mon, 15 Apr 2013 20:41:05 +0200	[thread overview]
Message-ID: <1366051272-12979-27-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1366051272-12979-1-git-send-email-rth@twiddle.net>

Nothing else in the call chain ensures that these
constants don't have garbage in the high bits.

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 tcg/ppc64/tcg-target.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c
index 84c7575..70cbb86 100644
--- a/tcg/ppc64/tcg-target.c
+++ b/tcg/ppc64/tcg-target.c
@@ -1059,6 +1059,11 @@ static void tcg_out_cmp(TCGContext *s, int cond, TCGArg arg1, TCGArg arg2,
     int imm;
     uint32_t op;
 
+    /* Simplify the comparisons below wrt CMPI.  */
+    if (type == TCG_TYPE_I32) {
+        arg2 = (int32_t)arg2;
+    }
+
     switch (cond) {
     case TCG_COND_EQ:
     case TCG_COND_NE:
-- 
1.8.1.4

  parent reply	other threads:[~2013-04-15 18:45 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-15 18:40 [Qemu-devel] [PATCH v5 00/33] Modernize tcg/ppc64 Richard Henderson
2013-04-15 18:40 ` [Qemu-devel] [PATCH v5 01/33] disas: Disassemble all ppc insns for the host Richard Henderson
2013-04-15 18:40 ` [Qemu-devel] [PATCH v5 02/33] tcg-ppc64: Use TCGReg everywhere Richard Henderson
2013-04-15 18:40 ` [Qemu-devel] [PATCH v5 03/33] tcg-ppc64: Introduce and use tcg_out_rlw Richard Henderson
2013-04-15 18:40 ` [Qemu-devel] [PATCH v5 04/33] tcg-ppc64: Introduce and use tcg_out_ext32u Richard Henderson
2013-04-15 18:40 ` [Qemu-devel] [PATCH v5 05/33] tcg-ppc64: Introduce and use tcg_out_shli64 Richard Henderson
2013-04-15 18:40 ` [Qemu-devel] [PATCH v5 06/33] tcg-ppc64: Introduce and use tcg_out_shri64 Richard Henderson
2013-04-15 18:40 ` [Qemu-devel] [PATCH v5 07/33] tcg-ppc64: Introduce and use TAI and SAI Richard Henderson
2013-04-15 18:40 ` [Qemu-devel] [PATCH v5 08/33] tcg-ppc64: Fix setcond_i32 Richard Henderson
2013-04-15 18:40 ` [Qemu-devel] [PATCH v5 09/33] tcg-ppc64: Cleanup tcg_out_movi Richard Henderson
2013-04-15 18:40 ` [Qemu-devel] [PATCH v5 10/33] tcg-ppc64: Rearrange integer constant constraints Richard Henderson
2013-04-15 18:40 ` [Qemu-devel] [PATCH v5 11/33] tcg-ppc64: Improve constant add and sub ops Richard Henderson
2013-04-15 18:40 ` [Qemu-devel] [PATCH v5 12/33] tcg-ppc64: Allow constant first argument to sub Richard Henderson
2013-04-15 18:40 ` [Qemu-devel] [PATCH v5 13/33] tcg-ppc64: Tidy or and xor patterns Richard Henderson
2013-04-15 18:40 ` [Qemu-devel] [PATCH v5 14/33] tcg-ppc64: Improve and_i32 with constant Richard Henderson
2013-04-15 18:40 ` [Qemu-devel] [PATCH v5 15/33] tcg-ppc64: Improve and_i64 " Richard Henderson
2013-04-15 18:40 ` [Qemu-devel] [PATCH v5 16/33] tcg-ppc64: Use automatic implementation of ext32u_i64 Richard Henderson
2013-04-15 18:40 ` [Qemu-devel] [PATCH v5 17/33] tcg-ppc64: Streamline qemu_ld/st insn selection Richard Henderson
2013-04-15 18:40 ` [Qemu-devel] [PATCH v5 18/33] tcg-ppc64: Implement rotates Richard Henderson
2013-04-15 18:40 ` [Qemu-devel] [PATCH v5 19/33] tcg-ppc64: Implement bswap16 and bswap32 Richard Henderson
2013-04-15 20:04   ` Aurelien Jarno
2013-04-15 18:40 ` [Qemu-devel] [PATCH v5 20/33] tcg-ppc64: Implement bswap64 Richard Henderson
2013-04-15 18:41 ` [Qemu-devel] [PATCH v5 21/33] tcg-ppc64: Implement compound logicals Richard Henderson
2013-04-15 18:41 ` [Qemu-devel] [PATCH v5 22/33] tcg-ppc64: Handle constant inputs for some " Richard Henderson
2013-04-15 18:41 ` [Qemu-devel] [PATCH v5 23/33] tcg-ppc64: Implement deposit Richard Henderson
2013-04-15 18:41 ` [Qemu-devel] [PATCH v5 24/33] tcg-ppc64: Use I constraint for mul Richard Henderson
2013-04-15 18:41 ` [Qemu-devel] [PATCH v5 25/33] tcg-ppc64: Use TCGType throughout compares Richard Henderson
2013-04-15 18:41 ` Richard Henderson [this message]
2013-04-15 18:41 ` [Qemu-devel] [PATCH v5 27/33] tcg-ppc64: Use MFOCRF instead of MFCR Richard Henderson
2013-04-15 18:41 ` [Qemu-devel] [PATCH v5 28/33] tcg-ppc64: Use ISEL for setcond Richard Henderson
2013-04-15 18:41 ` [Qemu-devel] [PATCH v5 29/33] tcg-ppc64: Implement movcond Richard Henderson
2013-04-15 18:41 ` [Qemu-devel] [PATCH v5 30/33] tcg-ppc64: Use getauxval for ISA detection Richard Henderson
2013-04-15 18:41 ` [Qemu-devel] [PATCH v5 31/33] tcg-ppc64: Implement add2/sub2_i64 Richard Henderson
2013-04-15 18:41 ` [Qemu-devel] [PATCH v5 32/33] tcg-ppc64: Implement mulu2/muls2_i64 Richard Henderson
2013-04-15 18:41 ` [Qemu-devel] [PATCH v5 33/33] tcg-ppc64: Handle deposit of zero Richard Henderson
2013-04-15 20:52 ` [Qemu-devel] [PATCH v5 00/33] Modernize tcg/ppc64 Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366051272-12979-27-git-send-email-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=aurelien@aurel32.net \
    --cc=av1474@comtv.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).