From: mrhines@linux.vnet.ibm.com
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, mst@redhat.com, owasserm@redhat.com,
abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com,
pbonzini@redhat.com
Subject: [Qemu-devel] [PULL 3/8] rdma: export ram_handle_compressed()
Date: Mon, 15 Apr 2013 22:44:41 -0400 [thread overview]
Message-ID: <1366080286-9288-4-git-send-email-mrhines@linux.vnet.ibm.com> (raw)
In-Reply-To: <1366080286-9288-1-git-send-email-mrhines@linux.vnet.ibm.com>
From: "Michael R. Hines" <mrhines@us.ibm.com>
This gives RDMA shared access to madvise() on the destination side
when an entire chunk is found to be zero.
Signed-off-by: Michael R. Hines <mrhines@us.ibm.com>
---
arch_init.c | 24 ++++++++++++++++--------
include/migration/migration.h | 1 +
2 files changed, 17 insertions(+), 8 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 92de1bd..e272852 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -770,6 +770,21 @@ static inline void *host_from_stream_offset(QEMUFile *f,
return NULL;
}
+/*
+ * If a page (or a whole RDMA chunk) has been
+ * determined to be zero, then zap it.
+ */
+void ram_handle_compressed(void *host, uint8_t ch, uint64_t size)
+{
+ memset(host, ch, TARGET_PAGE_SIZE);
+#ifndef _WIN32
+ if (ch == 0 && (!kvm_enabled() || kvm_has_sync_mmu()) &&
+ getpagesize() <= TARGET_PAGE_SIZE) {
+ qemu_madvise(host, size, QEMU_MADV_DONTNEED);
+ }
+#endif
+}
+
static int ram_load(QEMUFile *f, void *opaque, int version_id)
{
ram_addr_t addr;
@@ -837,14 +852,7 @@ static int ram_load(QEMUFile *f, void *opaque, int version_id)
}
ch = qemu_get_byte(f);
- memset(host, ch, TARGET_PAGE_SIZE);
-#ifndef _WIN32
- if (ch == 0 &&
- (!kvm_enabled() || kvm_has_sync_mmu()) &&
- getpagesize() <= TARGET_PAGE_SIZE) {
- qemu_madvise(host, TARGET_PAGE_SIZE, QEMU_MADV_DONTNEED);
- }
-#endif
+ ram_handle_compressed(host, ch, TARGET_PAGE_SIZE);
} else if (flags & RAM_SAVE_FLAG_PAGE) {
void *host;
diff --git a/include/migration/migration.h b/include/migration/migration.h
index f6df8d1..0f4510f 100644
--- a/include/migration/migration.h
+++ b/include/migration/migration.h
@@ -143,4 +143,5 @@ void ram_control_load_hook(QEMUFile *f, uint32_t flags);
size_t ram_control_save_page(QEMUFile *f, ram_addr_t block_offset,
ram_addr_t offset, size_t size);
+void ram_handle_compressed(void *host, uint8_t ch, uint64_t size);
#endif
--
1.7.10.4
next prev parent reply other threads:[~2013-04-16 2:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 2:44 [Qemu-devel] [PULL 0/8] rdma: migration support mrhines
2013-04-16 2:44 ` [Qemu-devel] [PULL 1/8] rdma: introduce qemu_ram_foreach_block mrhines
2013-04-16 2:44 ` [Qemu-devel] [PULL 2/8] rdma: new QEMUFileOps hooks mrhines
2013-04-16 3:24 ` Paolo Bonzini
2013-04-16 4:44 ` Michael R. Hines
2013-04-16 2:44 ` mrhines [this message]
2013-04-16 2:44 ` [Qemu-devel] [PULL 4/8] rdma: introduce capability for chunk registration mrhines
2013-04-16 4:50 ` Paolo Bonzini
2013-04-16 12:58 ` Eric Blake
2013-04-16 14:54 ` Michael R. Hines
2013-04-16 2:44 ` [Qemu-devel] [PULL 5/8] rdma: core rdma logic mrhines
2013-04-16 4:49 ` Paolo Bonzini
2013-04-16 6:09 ` Paolo Bonzini
2013-04-16 14:48 ` Michael R. Hines
2013-04-17 3:27 ` Michael R. Hines
2013-04-17 8:58 ` Paolo Bonzini
2013-04-17 15:59 ` Michael R. Hines
2013-04-17 16:48 ` Paolo Bonzini
2013-04-16 2:44 ` [Qemu-devel] [PULL 6/8] rdma: send pc.ram mrhines
2013-04-16 3:25 ` Paolo Bonzini
2013-04-16 2:44 ` [Qemu-devel] [PULL 7/8] rdma: print out throughput while debugging mrhines
2013-04-16 2:44 ` [Qemu-devel] [PULL 8/8] rdma: add documentation mrhines
2013-04-16 3:23 ` [Qemu-devel] [PULL 0/8] rdma: migration support Paolo Bonzini
2013-04-16 14:32 ` Anthony Liguori
2013-04-16 14:34 ` Paolo Bonzini
2013-04-16 15:42 ` Anthony Liguori
2013-04-16 14:52 ` Michael R. Hines
2013-04-16 14:53 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366080286-9288-4-git-send-email-mrhines@linux.vnet.ibm.com \
--to=mrhines@linux.vnet.ibm.com \
--cc=abali@us.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=gokul@us.ibm.com \
--cc=mrhines@us.ibm.com \
--cc=mst@redhat.com \
--cc=owasserm@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).