From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47368) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1US2MZ-0001Rp-PA for qemu-devel@nongnu.org; Tue, 16 Apr 2013 05:39:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1US2MX-0006tI-FO for qemu-devel@nongnu.org; Tue, 16 Apr 2013 05:39:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12472) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1US2MX-0006sj-7D for qemu-devel@nongnu.org; Tue, 16 Apr 2013 05:39:41 -0400 From: Gerd Hoffmann Date: Tue, 16 Apr 2013 11:39:16 +0200 Message-Id: <1366105178-26744-3-git-send-email-kraxel@redhat.com> In-Reply-To: <1366105178-26744-1-git-send-email-kraxel@redhat.com> References: <1366105178-26744-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH 02/24] hw/vmware_vga.c: fix screen resize bug introduced after console revamp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Igor Mitsyanko , Gerd Hoffmann From: Igor Mitsyanko In vmsvga display update function, a pointer to DisplaySurface must be acquired after a call to vmsvga_check_size since this function might replace current DisplaySurface with a new one. Signed-off-by: Igor Mitsyanko Signed-off-by: Gerd Hoffmann --- hw/display/vmware_vga.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c index bcad47a..2233a8b 100644 --- a/hw/display/vmware_vga.c +++ b/hw/display/vmware_vga.c @@ -995,7 +995,7 @@ static inline void vmsvga_check_size(struct vmsvga_state_s *s) static void vmsvga_update_display(void *opaque) { struct vmsvga_state_s *s = opaque; - DisplaySurface *surface = qemu_console_surface(s->vga.con); + DisplaySurface *surface; bool dirty = false; if (!s->enable) { @@ -1004,6 +1004,7 @@ static void vmsvga_update_display(void *opaque) } vmsvga_check_size(s); + surface = qemu_console_surface(s->vga.con); vmsvga_fifo_run(s); vmsvga_update_rect_flush(s); -- 1.7.9.7