From: Stefan Weil <sw@weilnetz.de>
To: qemu-trivial@nongnu.org
Cc: Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org, "Richard W.M. Jones" <rjones@redhat.com>
Subject: [Qemu-devel] [PATCH] block/ssh: Add missing gcc format attributes
Date: Thu, 18 Apr 2013 22:21:05 +0200 [thread overview]
Message-ID: <1366316465-32710-1-git-send-email-sw@weilnetz.de> (raw)
Now gcc will check whether format string and variable arguments match.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
Please note: I could only run limited tests with the new code
because ssh.c is currently not compiled in my w32/w64 environment.
Regards,
Stefan W.
block/ssh.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/ssh.c b/block/ssh.c
index 8f78e2e..b4e048c 100644
--- a/block/ssh.c
+++ b/block/ssh.c
@@ -109,7 +109,7 @@ static void ssh_state_free(BDRVSSHState *s)
/* Wrappers around error_report which make sure to dump as much
* information from libssh2 as possible.
*/
-static void
+static void GCC_FMT_ATTR(2, 3)
session_error_report(BDRVSSHState *s, const char *fs, ...)
{
va_list args;
@@ -132,7 +132,7 @@ session_error_report(BDRVSSHState *s, const char *fs, ...)
error_printf("\n");
}
-static void
+static void GCC_FMT_ATTR(2, 3)
sftp_error_report(BDRVSSHState *s, const char *fs, ...)
{
va_list args;
--
1.7.10.4
next reply other threads:[~2013-04-18 20:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 20:21 Stefan Weil [this message]
2013-04-18 20:42 ` [Qemu-devel] block/ssh: Compilation fails on Debian squeeze Stefan Weil
2013-04-18 21:08 ` Richard W.M. Jones
2013-04-19 4:10 ` Stefan Weil
2013-04-18 21:07 ` [Qemu-devel] [PATCH] block/ssh: Add missing gcc format attributes Richard W.M. Jones
2013-04-19 9:44 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366316465-32710-1-git-send-email-sw@weilnetz.de \
--to=sw@weilnetz.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).