From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USw5U-0004SC-3s for qemu-devel@nongnu.org; Thu, 18 Apr 2013 17:09:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USw5T-0000fy-5H for qemu-devel@nongnu.org; Thu, 18 Apr 2013 17:09:48 -0400 From: "Richard W.M. Jones" Date: Thu, 18 Apr 2013 22:09:33 +0100 Message-Id: <1366319373-12926-1-git-send-email-rjones@redhat.com> Subject: [Qemu-devel] [PATCH] ssh: Remove unnecessary use of strlen function. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-trivial@nongnu.org Cc: sw@weilnetz.de, qemu-devel@nongnu.org From: "Richard W.M. Jones" --- block/ssh.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index 8f78e2e..7bc008d 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -387,15 +387,13 @@ static int check_host_key(BDRVSSHState *s, const char *host, int port, } /* host_key_check=md5:xx:yy:zz:... */ - if (strlen(host_key_check) >= 4 && - strncmp(host_key_check, "md5:", 4) == 0) { + if (strncmp(host_key_check, "md5:", 4) == 0) { return check_host_key_hash(s, &host_key_check[4], LIBSSH2_HOSTKEY_HASH_MD5, 16); } /* host_key_check=sha1:xx:yy:zz:... */ - if (strlen(host_key_check) >= 5 && - strncmp(host_key_check, "sha1:", 5) == 0) { + if (strncmp(host_key_check, "sha1:", 5) == 0) { return check_host_key_hash(s, &host_key_check[5], LIBSSH2_HOSTKEY_HASH_SHA1, 20); } -- 1.8.1.4