From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USzfK-0005tx-5C for qemu-devel@nongnu.org; Thu, 18 Apr 2013 20:59:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USzfH-0006rv-Q2 for qemu-devel@nongnu.org; Thu, 18 Apr 2013 20:59:02 -0400 Received: from e28smtp01.in.ibm.com ([122.248.162.1]:51354) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USzfH-0006rd-8o for qemu-devel@nongnu.org; Thu, 18 Apr 2013 20:58:59 -0400 Received: from /spool/local by e28smtp01.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 19 Apr 2013 06:24:12 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id 51B49E002D for ; Fri, 19 Apr 2013 06:30:50 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3J0wjKl3277116 for ; Fri, 19 Apr 2013 06:28:45 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3J0wpC3017514 for ; Fri, 19 Apr 2013 10:58:51 +1000 From: Wenchao Xia Date: Fri, 19 Apr 2013 08:57:05 +0800 Message-Id: <1366333030-8564-1-git-send-email-xiawenc@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH V3 0/5] block: make qmp_transaction extendable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@gmail.com, dietmar@proxmox.com, pbonzini@redhat.com, Wenchao Xia This serial will package backing chain snapshot code as one case, to make it possible adding more operations later. v2: Address Kevin's comments: Use the same prototype prepare, commit, rollback model in original code, commit should never fail. v3: Address Stefan's comments: 3/5, 4/5: remove *action parameter since later only BlkTransactionStates* is needed. 5/5: embbed BlkTransactionStates in ExternalSnapshotStates, *opaque is removed, related call back function format change for external snapshot. Address Kevin's comments: removed all indention in commit message. 1/5: return void for prepare() function, *errp plays the role as error checker. 5/5: mark *commit callback must exist, *rollback callback can be NULL. Align "callback =" in "const BdrvActionOps external_snapshot_ops" to the same colum. Address Eric's comments: 1/5: better commit message. 5/5: better commit message and comments in code that only one of rollback() or commit() will be called. Wenchao Xia (5): 1 block: package preparation code in qmp_transaction() 2 block: move input parsing code in qmp_transaction() 3 block: package committing code in qmp_transaction() 4 block: package rollback code in qmp_transaction() 5 block: make all steps in qmp_transaction() as callback blockdev.c | 251 +++++++++++++++++++++++++++++++++++++++--------------------- 1 files changed, 163 insertions(+), 88 deletions(-)