From: Peter Maydell <peter.maydell@linaro.org>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>
Subject: [Qemu-devel] [PATCH 11/11] hw/versatile_pci: Drop unnecessary vpb_pci_config_addr()
Date: Fri, 19 Apr 2013 15:57:27 +0100 [thread overview]
Message-ID: <1366383447-13082-12-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1366383447-13082-1-git-send-email-peter.maydell@linaro.org>
Drop the vpb_pci_config_addr() function -- it is unnecessary since
the size of the memory regions means the hwaddr is always within
the 24 bit size. (This function was probably a leftover from when
read/write functions were called with absolute addresses rather
than relative ones.)
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Paul Brook <paul@codesourcery.com>
---
hw/pci-host/versatile.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/hw/pci-host/versatile.c b/hw/pci-host/versatile.c
index e99f35f..540daf7 100644
--- a/hw/pci-host/versatile.c
+++ b/hw/pci-host/versatile.c
@@ -214,11 +214,6 @@ static const MemoryRegionOps pci_vpb_reg_ops = {
},
};
-static inline uint32_t vpb_pci_config_addr(hwaddr addr)
-{
- return addr & 0xffffff;
-}
-
static void pci_vpb_config_write(void *opaque, hwaddr addr,
uint64_t val, unsigned size)
{
@@ -234,7 +229,7 @@ static void pci_vpb_config_write(void *opaque, hwaddr addr,
}
}
}
- pci_data_write(&s->pci_bus, vpb_pci_config_addr(addr), val, size);
+ pci_data_write(&s->pci_bus, addr, val, size);
}
static uint64_t pci_vpb_config_read(void *opaque, hwaddr addr,
@@ -242,7 +237,7 @@ static uint64_t pci_vpb_config_read(void *opaque, hwaddr addr,
{
PCIVPBState *s = opaque;
uint32_t val;
- val = pci_data_read(&s->pci_bus, vpb_pci_config_addr(addr), size);
+ val = pci_data_read(&s->pci_bus, addr, size);
return val;
}
--
1.7.9.5
next prev parent reply other threads:[~2013-04-19 14:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 14:57 [Qemu-devel] [PULL 00/11] arm-devs queue Peter Maydell
2013-04-19 14:57 ` [Qemu-devel] [PATCH 01/11] versatile_pci: Fix hardcoded tabs Peter Maydell
2013-04-19 14:57 ` [Qemu-devel] [PATCH 02/11] versatile_pci: Expose PCI I/O region on Versatile PB Peter Maydell
2013-04-19 14:57 ` [Qemu-devel] [PATCH 03/11] versatile_pci: Update to realize and instance init functions Peter Maydell
2013-04-19 14:57 ` [Qemu-devel] [PATCH 04/11] versatile_pci: Change to subclassing TYPE_PCI_HOST_BRIDGE Peter Maydell
2013-04-19 14:57 ` [Qemu-devel] [PATCH 05/11] versatile_pci: Use separate PCI I/O space rather than system I/O space Peter Maydell
2013-04-19 14:57 ` [Qemu-devel] [PATCH 06/11] versatile_pci: Put the host bridge PCI device at slot 29 Peter Maydell
2013-04-19 14:57 ` [Qemu-devel] [PATCH 07/11] versatile_pci: Implement the correct PCI IRQ mapping Peter Maydell
2013-04-19 14:57 ` [Qemu-devel] [PATCH 08/11] versatile_pci: Implement the PCI controller's control registers Peter Maydell
2013-04-19 14:57 ` [Qemu-devel] [PATCH 09/11] arm/realview: Fix mapping of PCI regions Peter Maydell
2013-04-19 14:57 ` [Qemu-devel] [PATCH 10/11] versatile_pci: Expose PCI memory space to system Peter Maydell
2013-04-19 14:57 ` Peter Maydell [this message]
2013-04-20 12:38 ` [Qemu-devel] [PULL 00/11] arm-devs queue Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366383447-13082-12-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=anthony@codemonkey.ws \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).