qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Igor Mammedov" <imammedo@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [RFC 4/7] pc: Use separate init functions for pc-*-1.4
Date: Thu, 25 Apr 2013 15:43:03 -0300	[thread overview]
Message-ID: <1366915386-14728-5-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1366915386-14728-1-git-send-email-ehabkost@redhat.com>

The pc-*-1.4 machine-types will have some compatibility calls, so make
them use different init functions from pc-*-1.5.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 hw/i386/pc_piix.c | 9 +++++++--
 hw/i386/pc_q35.c  | 7 ++++++-
 2 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 943758a..20708dc 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -235,10 +235,15 @@ static void pc_init_pci(QEMUMachineInitArgs *args)
              initrd_filename, cpu_model, 1, 1);
 }
 
+static void pc_init_pci_1_4(QEMUMachineInitArgs *args)
+{
+    pc_init_pci(args);
+}
+
 static void pc_init_pci_1_3(QEMUMachineInitArgs *args)
 {
     enable_compat_apic_id_mode();
-    pc_init_pci(args);
+    pc_init_pci_1_4(args);
 }
 
 /* PC machine init function for pc-0.14 to pc-1.2 */
@@ -309,7 +314,7 @@ static QEMUMachine pc_i440fx_machine_v1_5 = {
 static QEMUMachine pc_i440fx_machine_v1_4 = {
     .name = "pc-i440fx-1.4",
     .desc = "Standard PC (i440FX + PIIX, 1996)",
-    .init = pc_init_pci,
+    .init = pc_init_pci_1_4,
     .max_cpus = 255,
     .compat_props = (GlobalProperty[]) {
         PC_COMPAT_1_4,
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index 6ac1a89..7eb4a75 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -209,6 +209,11 @@ static void pc_q35_init(QEMUMachineInitArgs *args)
     }
 }
 
+static void pc_q35_init_1_4(QEMUMachineInitArgs *args)
+{
+    pc_q35_init(args);
+}
+
 static QEMUMachine pc_q35_machine_v1_5 = {
     .name = "pc-q35-1.5",
     .alias = "q35",
@@ -221,7 +226,7 @@ static QEMUMachine pc_q35_machine_v1_5 = {
 static QEMUMachine pc_q35_machine_v1_4 = {
     .name = "pc-q35-1.4",
     .desc = "Standard PC (Q35 + ICH9, 2009)",
-    .init = pc_q35_init,
+    .init = pc_q35_init_1_4,
     .max_cpus = 255,
     .compat_props = (GlobalProperty[]) {
         PC_COMPAT_1_4,
-- 
1.8.1.4

  parent reply	other threads:[~2013-04-25 18:43 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-25 18:42 [Qemu-devel] [RFC 0/7] CPUID fixes for 1.5 Eduardo Habkost
2013-04-25 18:43 ` [Qemu-devel] [RFC 1/7] target-i386: Introduce generic CPUID feature compat function Eduardo Habkost
2013-05-06 20:34   ` Andreas Färber
2013-04-25 18:43 ` [Qemu-devel] [RFC 2/7] target-i386: Introduce compat function to set CPUID 'level' Eduardo Habkost
2013-04-26 15:16   ` Igor Mammedov
2013-04-26 15:28     ` Eduardo Habkost
2013-04-25 18:43 ` [Qemu-devel] [RFC 3/7] target-i386: Introduce compat function to set CPUID 'model' Eduardo Habkost
2013-04-25 18:43 ` Eduardo Habkost [this message]
2013-04-25 18:43 ` [Qemu-devel] [RFC 5/7] target-i386: n270 can MOVBE Eduardo Habkost
2013-05-06 20:35   ` Andreas Färber
2013-04-25 18:43 ` [Qemu-devel] [RFC 6/7] target-i386: change CPUID model of 486 to 8 Eduardo Habkost
2013-04-25 19:11   ` Eduardo Habkost
2013-04-25 18:43 ` [Qemu-devel] [RFC 7/7] target-i386: Disable direct passthrough of PMU CPUID leaf by default Eduardo Habkost
2013-04-26 15:10   ` Igor Mammedov
2013-04-26 15:31     ` Eduardo Habkost
2013-04-26 15:33       ` Andreas Färber
2013-04-26 15:39         ` Igor Mammedov
2013-04-26 17:30           ` Eduardo Habkost
2013-04-26 17:41             ` Igor Mammedov
2013-04-26 19:01               ` Eduardo Habkost
2013-04-30 17:04                 ` Igor Mammedov
2013-04-30 19:57                   ` Eduardo Habkost
2013-05-01 11:14                     ` Andreas Färber
2013-05-02 14:43                       ` Eduardo Habkost
2013-05-02 14:50                         ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366915386-14728-5-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=afaerber@suse.de \
    --cc=imammedo@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).