From: Dominik Dingel <dingel@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Alexander Graf <agraf@suse.de>
Subject: [Qemu-devel] [PATCH 08/10] s390-ccw.img: Get queue config from host.
Date: Fri, 26 Apr 2013 14:12:55 +0200 [thread overview]
Message-ID: <1366978377-16823-9-git-send-email-dingel@linux.vnet.ibm.com> (raw)
In-Reply-To: <1366978377-16823-1-git-send-email-dingel@linux.vnet.ibm.com>
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Ask the host about the configuration instead of guessing it.
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
diff --git a/pc-bios/s390-ccw/virtio.c b/pc-bios/s390-ccw/virtio.c
index e0cede5..5b9e1dc 100644
--- a/pc-bios/s390-ccw/virtio.c
+++ b/pc-bios/s390-ccw/virtio.c
@@ -257,17 +257,21 @@ int virtio_read(ulong sector, void *load_addr)
void virtio_setup_block(struct subchannel_id schid)
{
struct vq_info_block info;
+ struct vq_config_block config = {};
virtio_reset(schid);
- /* XXX need to fetch the 128 from host */
- vring_init(&block, 128, (void*)(100 * 1024 * 1024),
+ config.index = 0;
+ if (run_ccw(schid, CCW_CMD_READ_VQ_CONF, &config, sizeof(config))) {
+ virtio_panic("Could not get block device configuration\n");
+ }
+ vring_init(&block, config.num, (void*)(100 * 1024 * 1024),
KVM_S390_VIRTIO_RING_ALIGN);
info.queue = (100ULL * 1024ULL* 1024ULL);
info.align = KVM_S390_VIRTIO_RING_ALIGN;
info.index = 0;
- info.num = 128;
+ info.num = config.num;
block.schid = schid;
if (!run_ccw(schid, CCW_CMD_SET_VQ, &info, sizeof(info))) {
diff --git a/pc-bios/s390-ccw/virtio.h b/pc-bios/s390-ccw/virtio.h
index a33199d..86fdd57 100644
--- a/pc-bios/s390-ccw/virtio.h
+++ b/pc-bios/s390-ccw/virtio.h
@@ -53,6 +53,11 @@ struct vq_info_block {
u16 num;
} __attribute__((packed));
+struct vq_config_block {
+ u16 index;
+ u16 num;
+} __attribute__((packed));
+
struct virtio_dev {
struct virtio_dev_header *header;
struct virtio_vqconfig *vqconfig;
--
1.7.9.5
next prev parent reply other threads:[~2013-04-26 12:13 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 12:12 [Qemu-devel] [PATCH 00/10] S390: Enhance s390 BIOS to enable bootdevice selection Dominik Dingel
2013-04-26 12:12 ` [Qemu-devel] [PATCH 01/10] Common: Add a default bootindex for all applicable devices Dominik Dingel
2013-04-26 15:19 ` Alexander Graf
2013-04-26 16:36 ` Anthony Liguori
2013-04-26 18:01 ` Dominik Dingel
2013-04-26 18:55 ` Anthony Liguori
2013-04-26 19:13 ` Gleb Natapov
2013-04-26 21:34 ` Dominik Dingel
2013-04-27 5:44 ` Gleb Natapov
2013-04-26 19:38 ` Christian Borntraeger
2013-04-26 12:12 ` [Qemu-devel] [PATCH 02/10] Common: Add quick access to first boot device Dominik Dingel
2013-04-26 16:37 ` Anthony Liguori
2013-04-26 12:12 ` [Qemu-devel] [PATCH 03/10] S390: Check Bootdevice Type Dominik Dingel
2013-04-26 15:22 ` Alexander Graf
2013-04-26 15:36 ` Dominik Dingel
2013-04-26 15:42 ` Christian Borntraeger
2013-04-26 15:48 ` Alexander Graf
2013-04-26 16:01 ` Christian Borntraeger
2013-04-26 16:05 ` Alexander Graf
2013-04-26 16:10 ` Dominik Dingel
2013-04-26 16:13 ` Alexander Graf
2013-04-26 16:11 ` Christian Borntraeger
2013-04-26 16:13 ` Alexander Graf
2013-04-26 16:45 ` Anthony Liguori
2013-04-26 16:04 ` Dominik Dingel
2013-04-26 16:07 ` Alexander Graf
2013-04-26 16:50 ` Alexander Graf
2013-04-26 12:12 ` [Qemu-devel] [PATCH 04/10] S390: check if BIOS is available and create links Dominik Dingel
2013-04-26 15:23 ` Alexander Graf
2013-04-26 15:48 ` Dominik Dingel
2013-04-26 15:57 ` Alexander Graf
2013-04-26 16:20 ` Dominik Dingel
2013-04-26 16:22 ` Alexander Graf
2013-04-26 16:38 ` Anthony Liguori
2013-04-26 18:03 ` Dominik Dingel
2013-04-26 18:04 ` Alexander Graf
2013-04-26 12:12 ` [Qemu-devel] [PATCH 05/10] s390-ccw.img: Detect devices with stsch Dominik Dingel
2013-04-26 12:12 ` [Qemu-devel] [PATCH 06/10] s390-ccw.img: Enhance drain_irqs() Dominik Dingel
2013-04-26 12:12 ` [Qemu-devel] [PATCH 07/10] s390-ccw.img: Rudimentary error checking Dominik Dingel
2013-04-26 12:12 ` Dominik Dingel [this message]
2013-04-26 12:12 ` [Qemu-devel] [PATCH 09/10] S390: Pass per-device loadparm values for CCW blk and net devs Dominik Dingel
2013-04-26 16:52 ` Alexander Graf
2013-04-26 18:08 ` Dominik Dingel
2013-04-26 18:14 ` Alexander Graf
2013-04-26 19:54 ` Christian Borntraeger
2013-04-26 12:12 ` [Qemu-devel] [PATCH 10/10] S390: Enabling device and program selection Dominik Dingel
2013-04-26 15:29 ` Alexander Graf
2013-04-26 16:56 ` Alexander Graf
2013-04-26 17:55 ` Dominik Dingel
2013-04-26 17:56 ` Alexander Graf
2013-04-26 16:19 ` [Qemu-devel] [PATCH 00/10] S390: Enhance s390 BIOS to enable bootdevice selection Alexander Graf
2013-04-26 16:22 ` Dominik Dingel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366978377-16823-9-git-send-email-dingel@linux.vnet.ibm.com \
--to=dingel@linux.vnet.ibm.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).