From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVmTC-0006aj-Q6 for qemu-devel@nongnu.org; Fri, 26 Apr 2013 13:30:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVmTB-00038p-Kb for qemu-devel@nongnu.org; Fri, 26 Apr 2013 13:30:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11389) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVmTB-00038G-De for qemu-devel@nongnu.org; Fri, 26 Apr 2013 13:30:01 -0400 From: Igor Mammedov Date: Fri, 26 Apr 2013 19:29:56 +0200 Message-Id: <1366997396-22996-1-git-send-email-imammedo@redhat.com> In-Reply-To: <517AAF7A.1080604@suse.de> References: <517AAF7A.1080604@suse.de> Subject: [Qemu-devel] [PATCH] target-i386: Do not allow to set apic-id one CPU is realized List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, afaerber@suse.de, ehabkost@redhat.com Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index f1cecc0..3152ad5 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1289,6 +1289,12 @@ static void x86_cpuid_set_apic_id(Object *obj, Visitor *v, void *opaque, Error *error = NULL; int64_t value; + if (DEVICE(obj)->realized) { + error_setg(errp, "Attempt to set property '%s' on '%s' after " + "it was realized", name, object_get_typename(obj)); + return; + } + visit_type_int(v, &value, name, &error); if (error) { error_propagate(errp, error); -- 1.8.2.1