From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: blauwirbel@gmail.com, sw@weilnetz.de
Subject: [Qemu-devel] [PATCH 2/5] win32: move Makefile dependencies on version-obj-y to rules.mak
Date: Sat, 27 Apr 2013 13:48:38 +0200 [thread overview]
Message-ID: <1367063321-19196-3-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1367063321-19196-1-git-send-email-pbonzini@redhat.com>
This makes the test on $(LIBTOOL) work. Otherwise, LIBTOOL
is /bin/false by the time the test is done.
Fixes Win32 compilation without a working cross-libtool.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
Makefile | 3 +--
rules.mak | 3 +++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 58e3527..f91f3b0 100644
--- a/Makefile
+++ b/Makefile
@@ -170,8 +170,7 @@ version.o: $(SRC_PATH)/version.rc config-host.h | version.lo
version.lo: $(SRC_PATH)/version.rc config-host.h
version-obj-$(CONFIG_WIN32) += version.o
-version-lobj-$(CONFIG_WIN32) += $(if $(LIBTOOL),version.lo)
-Makefile: $(version-obj-y) $(version-lobj-y)
+version-lobj-$(CONFIG_WIN32) += version.lo
######################################################################
diff --git a/rules.mak b/rules.mak
index 279525d..197a9d7 100644
--- a/rules.mak
+++ b/rules.mak
@@ -22,12 +22,15 @@ QEMU_CFLAGS += -I$(<D) -I$(@D)
%.o: %.rc
$(call quiet-command,$(WINDRES) -I. -o $@ $<," RC $(TARGET_DIR)$@")
+Makefile: $(version-obj-y)
+
ifeq ($(LIBTOOL),)
LIBTOOL = /bin/false
LINK = $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(CFLAGS) $(LDFLAGS) -o $@ \
$(sort $(filter %.o, $1)) $(filter-out %.o, $1) $(version-obj-y) \
$(LIBS)," LINK $(TARGET_DIR)$@")
else
+Makefile: $(version-lobj-y)
LIBTOOL += $(if $(V),,--quiet)
%.lo: %.c
$(call quiet-command,$(LIBTOOL) --mode=compile --tag=CC $(CC) $(QEMU_INCLUDES) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c -o $@ $<," lt CC $@")
--
1.8.2
next prev parent reply other threads:[~2013-04-27 11:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-27 11:48 [Qemu-devel] [PATCH 1.5 v5 0/5] fix win32 compilation Paolo Bonzini
2013-04-27 11:48 ` [Qemu-devel] [PATCH 1/5] win32: add generic RC rules to rules.mak Paolo Bonzini
2013-04-27 11:48 ` Paolo Bonzini [this message]
2013-04-27 11:48 ` [Qemu-devel] [PATCH 3/5] win32: generate console executable again Paolo Bonzini
2013-04-27 11:48 ` [Qemu-devel] [PATCH 4/5] add missing inclusions of config-host.h Paolo Bonzini
2013-04-27 13:11 ` Peter Maydell
2013-04-27 13:14 ` Paolo Bonzini
2013-04-27 13:19 ` Peter Maydell
2013-04-27 21:08 ` Paolo Bonzini
2013-04-27 11:48 ` [Qemu-devel] [PATCH 5/5] win32: add readv/writev emulation Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367063321-19196-3-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).