From: Jordan Justen <jordan.l.justen@intel.com>
To: qemu-devel@nongnu.org
Cc: Jordan Justen <jordan.l.justen@intel.com>
Subject: [Qemu-devel] [PATCH 4/6] pflash_cfi01: memory region should be set to enable readonly mode
Date: Sun, 28 Apr 2013 01:32:19 -0700 [thread overview]
Message-ID: <1367137941-4310-5-git-send-email-jordan.l.justen@intel.com> (raw)
In-Reply-To: <1367137941-4310-1-git-send-email-jordan.l.justen@intel.com>
This causes any writes to the memory region to trap to the
device handler.
This is also important for KVM, because this allows the memory
region to be set using KVM_MEM_READONLY, which allows the memory
region to be read & executed. (Without this, KVM will not support
executing from the memory region.)
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
---
hw/block/pflash_cfi01.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c
index 3ff20e0..b65225e 100644
--- a/hw/block/pflash_cfi01.c
+++ b/hw/block/pflash_cfi01.c
@@ -596,6 +596,8 @@ static int pflash_cfi01_init(SysBusDevice *dev)
}
}
+ memory_region_set_readonly(&pfl->mem, true);
+
if (pfl->bs) {
pfl->ro = bdrv_is_read_only(pfl->bs);
} else {
--
1.7.10.4
next prev parent reply other threads:[~2013-04-28 8:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-28 8:32 [Qemu-devel] [PATCH 0/6] KVM flash memory support Jordan Justen
2013-04-28 8:32 ` [Qemu-devel] [PATCH 1/6] kvm: add kvm_readonly_mem_enabled Jordan Justen
2013-04-29 10:27 ` Jan Kiszka
2013-04-28 8:32 ` [Qemu-devel] [PATCH 2/6] kvm: support using KVM_MEM_READONLY flag for readonly regions Jordan Justen
2013-05-03 6:02 ` Xiao Guangrong
2013-04-28 8:32 ` [Qemu-devel] [PATCH 3/6] kvm: workaround a possible KVM bug when using KVM_MEM_READONLY Jordan Justen
2013-04-29 10:29 ` Jan Kiszka
2013-04-29 18:37 ` Jordan Justen
2013-05-03 6:13 ` Xiao Guangrong
2013-04-28 8:32 ` Jordan Justen [this message]
2013-04-28 8:32 ` [Qemu-devel] [PATCH 5/6] pc_sysfw: allow flash memory to be used with KVM Jordan Justen
2013-04-28 8:32 ` [Qemu-devel] [PATCH 6/6] pc_sysfw: change rom_only default to 0 Jordan Justen
2013-04-29 8:20 ` Paolo Bonzini
2013-04-29 18:23 ` Jordan Justen
2013-04-29 21:10 ` Paolo Bonzini
2013-04-30 3:51 ` Jordan Justen
2013-04-30 7:24 ` Paolo Bonzini
2013-04-29 14:00 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367137941-4310-5-git-send-email-jordan.l.justen@intel.com \
--to=jordan.l.justen@intel.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).