From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43631) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWUjZ-0000ay-DK for qemu-devel@nongnu.org; Sun, 28 Apr 2013 12:45:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UWUjY-0003QH-6W for qemu-devel@nongnu.org; Sun, 28 Apr 2013 12:45:53 -0400 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Sun, 28 Apr 2013 18:45:47 +0200 Message-Id: <1367167547-19931-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH qtestfix for-1.5] libqos: Convert fw_cfg values to host endianness List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: blauwirbel@gmail.com, qemu-ppc@nongnu.org, =?UTF-8?q?Andreas=20F=C3=A4rber?= , anthony@codemonkey.ws The fw_cfg ABI is Little Endian, so byte-swap the generically read byte array to host endianness. This unbreaks the fw_cfg tests on ppc. Signed-off-by: Andreas F=C3=A4rber --- tests/libqos/fw_cfg.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/libqos/fw_cfg.c b/tests/libqos/fw_cfg.c index 799139e..e386ff7 100644 --- a/tests/libqos/fw_cfg.c +++ b/tests/libqos/fw_cfg.c @@ -11,6 +11,7 @@ */ =20 #include "libqos/fw_cfg.h" +#include "qemu/bswap.h" =20 void qfw_cfg_select(QFWCFG *fw_cfg, uint16_t key) { @@ -32,20 +33,20 @@ uint16_t qfw_cfg_get_u16(QFWCFG *fw_cfg, uint16_t key= ) { uint16_t value; qfw_cfg_get(fw_cfg, key, &value, sizeof(value)); - return value; + return le16_to_cpu(value); } =20 uint32_t qfw_cfg_get_u32(QFWCFG *fw_cfg, uint16_t key) { uint32_t value; qfw_cfg_get(fw_cfg, key, &value, sizeof(value)); - return value; + return le32_to_cpu(value); } =20 uint64_t qfw_cfg_get_u64(QFWCFG *fw_cfg, uint16_t key) { uint64_t value; qfw_cfg_get(fw_cfg, key, &value, sizeof(value)); - return value; + return le64_to_cpu(value); } =20 --=20 1.8.1.4