From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWtYx-0003xf-2Y for qemu-devel@nongnu.org; Mon, 29 Apr 2013 15:16:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UWtYu-0008T1-80 for qemu-devel@nongnu.org; Mon, 29 Apr 2013 15:16:34 -0400 Date: Mon, 29 Apr 2013 14:16:02 -0500 From: Scott Wood References: <1367246456-22382-1-git-send-email-Bharat.Bhushan@freescale.com> <1367257835.32182.2@snotra> <6A3DF150A5B70D4F9B66A25E3F7C888D06FFF514@039-SN2MPN1-011.039d.mgd.msft.net> In-Reply-To: <6A3DF150A5B70D4F9B66A25E3F7C888D06FFF514@039-SN2MPN1-011.039d.mgd.msft.net> (from R65777@freescale.com on Mon Apr 29 14:10:14 2013) Message-ID: <1367262962.32182.6@snotra> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] ppc: initialize GPRs as per epapr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bhushan Bharat-R65777 Cc: Wood Scott-B07421 , "qemu-devel@nongnu.org" , "agraf@suse.de" , Yoder Stuart-B08248 , "qemu-ppc@nongnu.org" , "david@gibson.dropbear.id.au" On 04/29/2013 02:10:14 PM, Bhushan Bharat-R65777 wrote: > > The caller needs both the "tsize" > > and the size in bytes, and you only call this wrapper once, so let =20 > the caller do > > the conversion instead. >=20 > Caller does not need to know both. It only need to know the size in =20 > bytes. >=20 > I think git diff make a mess of this. just trying to put the code for =20 > clarity OK, sorry... I misread the diff. -Scott=