From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38540) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWtbC-00079y-5P for qemu-devel@nongnu.org; Mon, 29 Apr 2013 15:18:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UWtb9-0000nX-8X for qemu-devel@nongnu.org; Mon, 29 Apr 2013 15:18:54 -0400 Date: Mon, 29 Apr 2013 14:18:44 -0500 From: Scott Wood References: <1367145009-14512-1-git-send-email-tiejun.chen@windriver.com> In-Reply-To: <1367145009-14512-1-git-send-email-tiejun.chen@windriver.com> (from tiejun.chen@windriver.com on Sun Apr 28 05:30:09 2013) Message-ID: <1367263124.32182.7@snotra> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-ppc] [v1][PATCH 1/1] PPC: e500: correct params->ram_size with ram_size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tiejun Chen Cc: qemu-ppc@nongnu.org, agraf@suse.de, qemu-devel@nongnu.org On 04/28/2013 05:30:09 AM, Tiejun Chen wrote: > We should sync params->ram_size after we fixup memory size on > a alignment boundary. Otherwise Guest would exceed the actual > memory region. >=20 > Signed-off-by: Tiejun Chen > --- > hw/ppc/e500.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c > index c1bdb6b..145da0e 100644 > --- a/hw/ppc/e500.c > +++ b/hw/ppc/e500.c > @@ -523,6 +523,8 @@ void ppce500_init(PPCE500Params *params) >=20 > /* Fixup Memory size on a alignment boundary */ > ram_size &=3D ~(RAM_SIZES_ALIGN - 1); > + /* Sync this for the system. */ > + params->ram_size =3D ram_size; Could you explain this further? When does params->ram_size ever get =20 used after this point? -Scott=