From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: anthony.perard@citrix.com, pbonzini@redhat.com,
aliguori@us.ibm.com, afaerber@suse.de, ehabkost@redhat.com
Subject: [Qemu-devel] [PATCH 3/5] add cpu_model to QEMUMachine
Date: Tue, 30 Apr 2013 15:41:26 +0200 [thread overview]
Message-ID: <1367329288-27178-4-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1367329288-27178-1-git-send-email-imammedo@redhat.com>
1. Use default cpu_model from machine if user haven't provided it.
It will allow statically define default cpu_model instead of
dynamically setting default value.
2. Provides globally accessible cpu_model via current_machine pointer.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
Note:
1. it will allow to remove dynamic setting of default cpu_model in pc.c:pc_cpus_init()
and simplify pc_init_isa() since default value will be defined as machine
definition.
2. it will be used for cpu-add hook that will be set by target-i386.
---
include/hw/boards.h | 1 +
vl.c | 6 ++++++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/include/hw/boards.h b/include/hw/boards.h
index 75cd127..4ced60a 100644
--- a/include/hw/boards.h
+++ b/include/hw/boards.h
@@ -44,6 +44,7 @@ typedef struct QEMUMachine {
struct QEMUMachine *next;
const char *hw_version;
void (*hot_add_cpu)(const int64_t id, Error **errp);
+ const char *cpu_model;
} QEMUMachine;
int qemu_register_machine(QEMUMachine *m);
diff --git a/vl.c b/vl.c
index 7d30af5..3df6021 100644
--- a/vl.c
+++ b/vl.c
@@ -4283,6 +4283,12 @@ int main(int argc, char **argv, char **envp)
qdev_machine_init();
+ if (cpu_model) {
+ machine->cpu_model = cpu_model;
+ } else {
+ cpu_model = machine->cpu_model;
+ }
+
QEMUMachineInitArgs args = { .ram_size = ram_size,
.boot_device = (boot_devices[0] == '\0') ?
machine->boot_order :
--
1.7.1
next prev parent reply other threads:[~2013-04-30 13:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 13:41 [Qemu-devel] [PATCH 0/5 v9 for-1.5] target-i386: CPU hot-add with cpu-add QMP command Igor Mammedov
2013-04-30 13:41 ` [Qemu-devel] [PATCH 1/5] add hot_add_cpu hook to QEMUMachine Igor Mammedov
2013-04-30 14:19 ` Eduardo Habkost
2013-04-30 15:48 ` Andreas Färber
2013-04-30 13:41 ` [Qemu-devel] [PATCH 2/5] QMP: add cpu-add command Igor Mammedov
2013-04-30 14:19 ` Eduardo Habkost
2013-04-30 15:58 ` Andreas Färber
2013-04-30 13:41 ` Igor Mammedov [this message]
2013-04-30 14:30 ` [Qemu-devel] [PATCH 3/5] add cpu_model to QEMUMachine Eduardo Habkost
2013-04-30 14:48 ` [Qemu-devel] [PATCH] target-arm: cpu: set default cpu_model via QEMUMachine.cpu_model Igor Mammedov
2013-04-30 14:55 ` Peter Maydell
2013-04-30 15:01 ` Igor Mammedov
2013-04-30 15:06 ` Eduardo Habkost
2013-04-30 14:54 ` [Qemu-devel] [PATCH 3/5] add cpu_model to QEMUMachine Peter Maydell
2013-04-30 15:14 ` Igor Mammedov
2013-04-30 15:32 ` Peter Maydell
2013-04-30 13:41 ` [Qemu-devel] [PATCH 4/5] target-i386: get default cpu_model from QEMUMachine Igor Mammedov
2013-04-30 14:47 ` Eduardo Habkost
2013-04-30 13:41 ` [Qemu-devel] [PATCH 5/5] target-i386: implement machine->hot_add_cpu hook Igor Mammedov
2013-04-30 16:00 ` Igor Mammedov
2013-04-30 16:31 ` Eduardo Habkost
2013-05-01 19:32 ` Andreas Färber
2013-05-02 7:18 ` Igor Mammedov
2013-05-02 11:46 ` Andreas Färber
2013-04-30 16:32 ` [Qemu-devel] [PATCH 5/5 v10] " Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367329288-27178-4-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=anthony.perard@citrix.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).