From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59380)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1UXK5r-0007tu-K0
	for qemu-devel@nongnu.org; Tue, 30 Apr 2013 19:36:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1UXK5n-0002u2-Az
	for qemu-devel@nongnu.org; Tue, 30 Apr 2013 19:36:19 -0400
Received: from co9ehsobe003.messaging.microsoft.com ([207.46.163.26]:44800
	helo=co9outboundpool.messaging.microsoft.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1UXK5n-0002tw-3U
	for qemu-devel@nongnu.org; Tue, 30 Apr 2013 19:36:15 -0400
Date: Tue, 30 Apr 2013 18:36:04 -0500
From: Scott Wood <scottwood@freescale.com>
References: <1367145009-14512-1-git-send-email-tiejun.chen@windriver.com>
	<1367263124.32182.7@snotra>
	<82C960D7DF4A1F47B94FC1C67A29BEE3669305D1@ALA-MBB.corp.ad.wrs.com>
	<1367363329.24133.12@snotra>
	<82C960D7DF4A1F47B94FC1C67A29BEE3669325EA@ALA-MBB.corp.ad.wrs.com>
In-Reply-To: <82C960D7DF4A1F47B94FC1C67A29BEE3669325EA@ALA-MBB.corp.ad.wrs.com>
	(from Tiejun.Chen@windriver.com on Tue Apr 30 18:31:41 2013)
Message-ID: <1367364964.24133.18@snotra>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [Qemu-ppc] [v1][PATCH 1/1] PPC: e500: correct
 params->ram_size with ram_size
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Chen, Tiejun" <Tiejun.Chen@windriver.com>
Cc: "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>, "agraf@suse.de" <agraf@suse.de>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 04/30/2013 06:31:41 PM, Chen, Tiejun wrote:
> > function that gets called later.  The comment doesn't make
>=20
> Are you saying I should replace cpu_to_be64(params->ram_size) with =20
> cpu_to_be64(ram_size) directly in ppce500_load_device_tree()?

No, I'm saying to reword (or eliminate) the confusing comment.

> But as I understand we should sync this global argument after we =20
> fixup something associated to that since params->ram_size may impact =20
> on something else in the future.

...and we just hope that nothing uses it for anything important before =20
the fixup. :-P

-Scott=