From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53187) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXMAB-0005rM-HF for qemu-devel@nongnu.org; Tue, 30 Apr 2013 21:49:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXMA6-000704-F6 for qemu-devel@nongnu.org; Tue, 30 Apr 2013 21:48:55 -0400 From: Scott Wood Date: Tue, 30 Apr 2013 20:48:25 -0500 Message-ID: <1367372912-23519-2-git-send-email-scottwood@freescale.com> In-Reply-To: <1367372912-23519-1-git-send-email-scottwood@freescale.com> References: <1367372912-23519-1-git-send-email-scottwood@freescale.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH 2/9] KVM: PPC: Add dummy kvm_arch_init_irq_routing() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Scott Wood , qemu-ppc@nongnu.org, qemu-devel@nongnu.org The common KVM code insists on calling kvm_arch_init_irq_routing() as soon as it sees kernel header support for it (regardless of whether QEMU supports it). Provide a dummy function to satisfy this. Unlike x86, PPC does not have one default irqchip, so there's no common code that we'd stick here. Even if you ignore the routes themselves, which even on x86 are not set up in this function, the initial XICS kernel implementation will not support IRQ routing, so it's best to leave even the general feature flags up to the specific irqchip code. Signed-off-by: Scott Wood --- Perhaps we shouldn't require each architecture to add a dummy function, but I wasn't sure if weak functions were acceptable in QEMU (didn't see any existing), and likewise with defining something like HAVE_ARCH_INIT_IRQ_ROUTING (which header would it go in?). --- target-ppc/kvm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c index 725071e..fe688ac 100644 --- a/target-ppc/kvm.c +++ b/target-ppc/kvm.c @@ -1799,3 +1799,7 @@ int kvm_arch_on_sigbus(int code, void *addr) { return 1; } + +void kvm_arch_init_irq_routing(KVMState *s) +{ +} -- 1.7.10.4