From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40141) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXR2g-0002wC-0L for qemu-devel@nongnu.org; Wed, 01 May 2013 03:01:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXR2b-0003ik-Ow for qemu-devel@nongnu.org; Wed, 01 May 2013 03:01:29 -0400 Received: from mga14.intel.com ([143.182.124.37]:25192) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXR2b-0003ho-Hh for qemu-devel@nongnu.org; Wed, 01 May 2013 03:01:25 -0400 From: Jordan Justen Date: Tue, 30 Apr 2013 23:56:31 -0700 Message-Id: <1367391393-6830-5-git-send-email-jordan.l.justen@intel.com> In-Reply-To: <1367391393-6830-1-git-send-email-jordan.l.justen@intel.com> References: <1367391393-6830-1-git-send-email-jordan.l.justen@intel.com> Subject: [Qemu-devel] [PATCH v2 4/6] pflash_cfi01: memory region should be set to enable readonly mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Jordan Justen This causes any writes to the memory region to trap to the device handler. This is also important for KVM, because this allows the memory region to be set using KVM_MEM_READONLY, which allows the memory region to be read & executed. (Without this, KVM will not support executing from the memory region.) Signed-off-by: Jordan Justen --- hw/block/pflash_cfi01.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c index 3ff20e0..b65225e 100644 --- a/hw/block/pflash_cfi01.c +++ b/hw/block/pflash_cfi01.c @@ -596,6 +596,8 @@ static int pflash_cfi01_init(SysBusDevice *dev) } } + memory_region_set_readonly(&pfl->mem, true); + if (pfl->bs) { pfl->ro = bdrv_is_read_only(pfl->bs); } else { -- 1.7.10.4