qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: ehabkost@redhat.com, "Michael S. Tsirkin" <mst@redhat.com>,
	pbonzini@redhat.com, anthony@codemonkey.ws,
	"H. Peter Anvin" <hpa@zytor.com>,
	imammedo@redhat.com, "Borislav Petkov" <bp@suse.de>,
	"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH qom-cpu for-1.5 0/4] target-i386: X86CPU compatibility properties
Date: Wed,  1 May 2013 18:07:16 +0200	[thread overview]
Message-ID: <1367424440-16687-1-git-send-email-afaerber@suse.de> (raw)

Hello,

It's easier adapting the infrastructure to our needs than working around it:
X86CPU already has QOM properties today. What's lacking is model subclasses,
and with the one X86CPU type its global properties are overwritten by models.
But we already know the designated naming scheme for the models!

So let's simply prepare compat_props for CPU models and make sure they are
already picked up today.

This works just fine for changing the 486 CPUID model value and avoids to
redo the PC part once we have X86CPU subclasses.
Tested using: ./QMP/qom-get /machine/icc-bridge/icc/child[0].model

For changing n270 CPUID flags we'll still need to resort to Eduardo's proposed
helper functions for now.

Regards,
Andreas

Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: Anthony Liguori <anthony@codemonkey.ws>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Michael S. Tsirkin <mst@redhat.com>

Andreas Färber (4):
  qdev: Let qdev_prop_parse() pass through Error
  qdev: Introduce qdev_prop_set_custom_globals()
  target-i386: Emulate X86CPU subclasses for global properties
  target-i386: Change CPUID model of 486 to 8

 hw/core/qdev-properties.c    | 50 ++++++++++++++++++++++++++------------------
 hw/core/qdev.c               |  7 ++++++-
 include/hw/i386/pc.h         |  4 ++++
 include/hw/qdev-properties.h |  7 +++++--
 qdev-monitor.c               |  6 +++++-
 target-i386/cpu.c            | 11 +++++++++-
 6 files changed, 60 insertions(+), 25 deletions(-)

-- 
1.8.1.4

             reply	other threads:[~2013-05-01 16:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-01 16:07 Andreas Färber [this message]
2013-05-01 16:07 ` [Qemu-devel] [PATCH qom-cpu for-1.5 1/4] qdev: Let qdev_prop_parse() pass through Error Andreas Färber
2013-05-02 18:55   ` Eduardo Habkost
2013-05-01 16:07 ` [Qemu-devel] [PATCH qom-cpu for-1.5 2/4] qdev: Introduce qdev_prop_set_custom_globals() Andreas Färber
2013-05-02 19:08   ` Eduardo Habkost
2013-05-06 17:50   ` Andreas Färber
2013-05-01 16:07 ` [Qemu-devel] [PATCH qom-cpu for-1.5 3/4] target-i386: Emulate X86CPU subclasses for global properties Andreas Färber
2013-05-02 15:03   ` Eduardo Habkost
2013-05-01 16:07 ` [Qemu-devel] [PATCH qom-cpu for-1.5 4/4] target-i386: Change CPUID model of 486 to 8 Andreas Färber
2013-05-02 15:48   ` Eduardo Habkost
2013-05-03 16:46 ` [Qemu-devel] [PATCH qom-cpu for-1.5 0/4] target-i386: X86CPU compatibility properties Anthony Liguori
2013-05-03 17:11   ` Igor Mammedov
2013-05-03 17:26   ` Andreas Färber
2013-05-06 18:22 ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367424440-16687-1-git-send-email-afaerber@suse.de \
    --to=afaerber@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=bp@suse.de \
    --cc=ehabkost@redhat.com \
    --cc=hpa@zytor.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).