qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [v2][Qemu-ppc][PATCH 1/1] PPC: e500: correct params->ram_size with ram_size
@ 2013-05-02  1:22 Tiejun Chen
  2013-05-02 11:17 ` Alexander Graf
  0 siblings, 1 reply; 2+ messages in thread
From: Tiejun Chen @ 2013-05-02  1:22 UTC (permalink / raw)
  To: agraf; +Cc: qemu-ppc, qemu-devel

We should sync params->ram_size after we fixup memory size on
a alignment boundary. Otherwise Guest would exceed the actual
memory region.

Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com>
---
v2: 

eliminate that original comment in v1.

 hw/ppc/e500.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
index c1bdb6b..3978f84 100644
--- a/hw/ppc/e500.c
+++ b/hw/ppc/e500.c
@@ -523,6 +523,7 @@ void ppce500_init(PPCE500Params *params)
 
     /* Fixup Memory size on a alignment boundary */
     ram_size &= ~(RAM_SIZES_ALIGN - 1);
+    params->ram_size = ram_size;
 
     /* Register Memory */
     memory_region_init_ram(ram, "mpc8544ds.ram", ram_size);
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [v2][Qemu-ppc][PATCH 1/1] PPC: e500: correct params->ram_size with ram_size
  2013-05-02  1:22 [Qemu-devel] [v2][Qemu-ppc][PATCH 1/1] PPC: e500: correct params->ram_size with ram_size Tiejun Chen
@ 2013-05-02 11:17 ` Alexander Graf
  0 siblings, 0 replies; 2+ messages in thread
From: Alexander Graf @ 2013-05-02 11:17 UTC (permalink / raw)
  To: Tiejun Chen; +Cc: qemu-ppc, qemu-devel


On 02.05.2013, at 03:22, Tiejun Chen wrote:

> We should sync params->ram_size after we fixup memory size on
> a alignment boundary. Otherwise Guest would exceed the actual
> memory region.
> 
> Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com>

Thanks, applied to ppc-next.

Alex

> ---
> v2: 
> 
> eliminate that original comment in v1.
> 
> hw/ppc/e500.c |    1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
> index c1bdb6b..3978f84 100644
> --- a/hw/ppc/e500.c
> +++ b/hw/ppc/e500.c
> @@ -523,6 +523,7 @@ void ppce500_init(PPCE500Params *params)
> 
>     /* Fixup Memory size on a alignment boundary */
>     ram_size &= ~(RAM_SIZES_ALIGN - 1);
> +    params->ram_size = ram_size;
> 
>     /* Register Memory */
>     memory_region_init_ram(ram, "mpc8544ds.ram", ram_size);
> -- 
> 1.7.9.5
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-05-02 11:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-02  1:22 [Qemu-devel] [v2][Qemu-ppc][PATCH 1/1] PPC: e500: correct params->ram_size with ram_size Tiejun Chen
2013-05-02 11:17 ` Alexander Graf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).