* [Qemu-devel] [PATCH for-1.5] configure: Check that "libtool" is not the MacOSX one
@ 2013-05-04 20:57 Peter Maydell
2013-05-07 18:49 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Peter Maydell @ 2013-05-04 20:57 UTC (permalink / raw)
To: qemu-devel; +Cc: Anthony Liguori, Andreas Färber, Peter Cheung, patches
The "libtool" binary on MacOSX is not GNU libtool, and doesn't support
anything like the same set of command line options. Test whether we
have accidentally picked this up (by looking for whether it handles
the GNU --version switch), and discard it if so. The fallback machinery
for the "we don't have a libtool" case will work fine. This fixes a
failure in "make install" on MacOSX.
Reported-by: Peter Cheung <mcheung63@hotmail.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
configure | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/configure b/configure
index e818e8b..a9ff4ad 100755
--- a/configure
+++ b/configure
@@ -1685,6 +1685,14 @@ if ! has $libtool; then
libtool=
fi
+# MacOSX ships with a libtool which isn't the GNU one; weed this
+# out by checking whether libtool supports the --version switch
+if test -n "$libtool"; then
+ if ! "$libtool" --version >/dev/null 2>&1; then
+ libtool=
+ fi
+fi
+
##########################################
# Sparse probe
if test "$sparse" != "no" ; then
--
1.7.11.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH for-1.5] configure: Check that "libtool" is not the MacOSX one
2013-05-04 20:57 [Qemu-devel] [PATCH for-1.5] configure: Check that "libtool" is not the MacOSX one Peter Maydell
@ 2013-05-07 18:49 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2013-05-07 18:49 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: Anthony Liguori, None, Peter Cheung, patches
Applied. Thanks.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-07 18:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-04 20:57 [Qemu-devel] [PATCH for-1.5] configure: Check that "libtool" is not the MacOSX one Peter Maydell
2013-05-07 18:49 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).