qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: qemu-ppc@nongnu.org
Cc: blauwirbel@gmail.com, Alexey Kardashevskiy <aik@ozlabs.ru>,
	anthony@codemonkey.ws, qemu-devel@nongnu.org,
	aurelien@aurel32.net
Subject: [Qemu-devel] [PATCH 9/9] spapr_llan: fix device reenabling
Date: Mon,  6 May 2013 17:25:17 +0200	[thread overview]
Message-ID: <1367853917-2015-10-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1367853917-2015-1-git-send-email-agraf@suse.de>

From: Alexey Kardashevskiy <aik@ozlabs.ru>

Normally, the "tap" device is polled by QEMU if a guest NIC can
receive packets. If a guest NIC is stopped during transfer (rmmod or
ifdown), it may still have packets in a queue which have to be send
to the guest before QEMU enables polling of a "tap" interface via
tap_update_fd_handler().

However the spapr_llan device was missing the qemu_flush_queued_packets()
call so the tap_send_completed() callback was never called and therefore
"tap" interface polling was not enabled ever.

The patch fixes this problem.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
 hw/net/spapr_llan.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/hw/net/spapr_llan.c b/hw/net/spapr_llan.c
index 3150add..03a09f2 100644
--- a/hw/net/spapr_llan.c
+++ b/hw/net/spapr_llan.c
@@ -336,6 +336,8 @@ static target_ulong h_register_logical_lan(PowerPCCPU *cpu,
     spapr_vio_dma_set(sdev, VLAN_BD_ADDR(rec_queue), 0, VLAN_BD_LEN(rec_queue));
 
     dev->isopen = 1;
+    qemu_flush_queued_packets(qemu_get_queue(dev->nic));
+
     return H_SUCCESS;
 }
 
-- 
1.6.0.2

  parent reply	other threads:[~2013-05-06 15:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-06 15:25 [Qemu-devel] [PULL 1.5 0/9] ppc patch queue 2013-05-06 Alexander Graf
2013-05-06 15:25 ` [Qemu-devel] [PATCH 1/9] pseries: Factor out check for out-of-bounds LIOBN Alexander Graf
2013-05-06 15:25 ` [Qemu-devel] [PATCH 2/9] pseries: Fix debug message for out-of-bounds address in H_PUT_TCE Alexander Graf
2013-05-06 15:25 ` [Qemu-devel] [PATCH 3/9] PPC: e500: initialize GPRs as per epapr Alexander Graf
2013-05-06 15:25 ` [Qemu-devel] [PATCH 4/9] pseries: Update SLOF firmware image Alexander Graf
2013-05-06 15:25 ` [Qemu-devel] [PATCH 5/9] PPC: Add MMU type for 2.06 with AMR but no TB pages Alexander Graf
2013-05-06 15:25 ` [Qemu-devel] [PATCH 6/9] target-ppc: Fix invalid SPR read/write warnings Alexander Graf
2013-05-06 15:25 ` [Qemu-devel] [PATCH 7/9] target-ppc: Add read and write of PPR SPR Alexander Graf
2013-05-06 15:25 ` [Qemu-devel] [PATCH 8/9] PPC: e500: correct params->ram_size with ram_size Alexander Graf
2013-05-06 15:25 ` Alexander Graf [this message]
2013-05-06 18:21 ` [Qemu-devel] [PULL 1.5 0/9] ppc patch queue 2013-05-06 Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367853917-2015-10-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=anthony@codemonkey.ws \
    --cc=aurelien@aurel32.net \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).