qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: qemu-devel@nongnu.org
Cc: blauwirbel@gmail.com, Dominik Dingel <dingel@linux.vnet.ibm.com>,
	anthony@codemonkey.ws, aurelien@aurel32.net
Subject: [Qemu-devel] [PATCH 3/6] S390: Merging s390_ipl_cpu and s390_ipl_reset
Date: Mon,  6 May 2013 17:30:21 +0200	[thread overview]
Message-ID: <1367854224-2354-4-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1367854224-2354-1-git-send-email-agraf@suse.de>

From: Dominik Dingel <dingel@linux.vnet.ibm.com>

There is no use in have this splitted in two functions.

Signed-off-by: Dominik Dingel <dingel@linux.vnet.ibm.com>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
 hw/s390x/ipl.c |   16 +++++-----------
 1 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
index cc3cd23..d14c548 100644
--- a/hw/s390x/ipl.c
+++ b/hw/s390x/ipl.c
@@ -57,16 +57,6 @@ typedef struct S390IPLState {
 } S390IPLState;
 
 
-static void s390_ipl_cpu(uint64_t pswaddr)
-{
-    S390CPU *cpu = S390_CPU(qemu_get_cpu(0));
-    CPUS390XState *env = &cpu->env;
-
-    env->psw.addr = pswaddr;
-    env->psw.mask = IPL_PSW_MASK;
-    s390_add_running_cpu(cpu);
-}
-
 static int s390_ipl_init(SysBusDevice *dev)
 {
     S390IPLState *ipl = S390_IPL(dev);
@@ -155,8 +145,12 @@ static Property s390_ipl_properties[] = {
 static void s390_ipl_reset(DeviceState *dev)
 {
     S390IPLState *ipl = S390_IPL(dev);
+    S390CPU *cpu = S390_CPU(qemu_get_cpu(0));
+    CPUS390XState *env = &cpu->env;
 
-    s390_ipl_cpu(ipl->start_addr);
+    env->psw.addr = ipl->start_addr;
+    env->psw.mask = IPL_PSW_MASK;
+    s390_add_running_cpu(cpu);
 }
 
 static void s390_ipl_class_init(ObjectClass *klass, void *data)
-- 
1.6.0.2

  parent reply	other threads:[~2013-05-06 15:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-06 15:30 [Qemu-devel] [PULL 1.5 0/6] s390 patch queue 2013-05-06 Alexander Graf
2013-05-06 15:30 ` [Qemu-devel] [PATCH 1/6] S390: BIOS check for file Alexander Graf
2013-05-06 15:30 ` [Qemu-devel] [PATCH 2/6] S390: BIOS create link to src folder for .img file Alexander Graf
2013-05-06 15:30 ` Alexander Graf [this message]
2013-05-06 15:30 ` [Qemu-devel] [PATCH 4/6] S390: Add virtio-blk boot Alexander Graf
2013-05-06 15:30 ` [Qemu-devel] [PATCH 5/6] S390: BIOS boot from given device Alexander Graf
2013-05-06 15:30 ` [Qemu-devel] [PATCH 6/6] s390: update s390-ccw.img Alexander Graf
2013-05-06 18:22 ` [Qemu-devel] [PULL 1.5 0/6] s390 patch queue 2013-05-06 Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367854224-2354-4-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=aurelien@aurel32.net \
    --cc=blauwirbel@gmail.com \
    --cc=dingel@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).