From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Andreas Färber" <afaerber@suse.de>, "H. Peter Anvin" <hpa@zytor.com>
Subject: [Qemu-devel] [PULL 09/11] target-i386: Change CPUID model of 486 to 8
Date: Mon, 6 May 2013 22:43:29 +0200 [thread overview]
Message-ID: <1367873011-7402-10-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1367873011-7402-1-git-send-email-afaerber@suse.de>
This changes the model number of 486 to 8 (DX4) which matches the
feature set presented, and actually has the CPUID instruction.
This adds a compatibility property, to keep model=0 on pc-*-1.4 and older.
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
[AF: Add compat_props entry]
Tested-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
include/hw/i386/pc.h | 4 ++++
target-i386/cpu.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 41869e5..417afe4 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -242,6 +242,10 @@ int e820_add_entry(uint64_t, uint64_t, uint32_t);
.driver = "pc-sysfw",\
.property = "rom_only",\
.value = stringify(0),\
+ },{\
+ .driver = "486-" TYPE_X86_CPU,\
+ .property = "model",\
+ .value = stringify(0),\
}
#endif
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index b438478..8e21c94 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -588,7 +588,7 @@ static x86_def_t builtin_x86_defs[] = {
.level = 1,
.vendor = CPUID_VENDOR_INTEL,
.family = 4,
- .model = 0,
+ .model = 8,
.stepping = 0,
.features[FEAT_1_EDX] =
I486_FEATURES,
--
1.8.1.4
next prev parent reply other threads:[~2013-05-06 20:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 20:43 [Qemu-devel] [PULL for-1.5 00/11] QOM CPUState patch queue 2013-05-06 Andreas Färber
2013-05-06 20:43 ` [Qemu-devel] [PULL 01/11] target-i386: Add ECX information to FeatureWordInfo Andreas Färber
2013-05-06 20:43 ` [Qemu-devel] [PULL 02/11] target-i386: Use FeatureWord loop on filter_features_for_kvm() Andreas Färber
2013-05-06 20:43 ` [Qemu-devel] [PULL 03/11] target-i386: Add "feature-words" property to X86CPU Andreas Färber
2013-05-06 20:43 ` [Qemu-devel] [PULL 04/11] target-i386: Introduce X86CPU::filtered_features field Andreas Färber
2013-05-06 20:43 ` [Qemu-devel] [PULL 05/11] target-i386: Add "filtered-features" property to X86CPU Andreas Färber
2013-05-06 20:43 ` [Qemu-devel] [PULL 06/11] qdev: Let qdev_prop_parse() pass through Error Andreas Färber
2013-05-06 20:43 ` [Qemu-devel] [PULL 07/11] qdev: Introduce qdev_prop_set_globals_for_type() Andreas Färber
2013-05-06 20:43 ` [Qemu-devel] [PULL 08/11] target-i386: Emulate X86CPU subclasses for global properties Andreas Färber
2013-05-06 20:43 ` Andreas Färber [this message]
2013-05-06 20:43 ` [Qemu-devel] [PULL 10/11] target-i386: Introduce generic CPUID feature compat function Andreas Färber
2013-05-06 20:43 ` [Qemu-devel] [PULL 11/11] target-i386: n270 can MOVBE Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367873011-7402-10-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=hpa@zytor.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).