qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PULL 04/11] target-i386: Introduce X86CPU::filtered_features field
Date: Mon,  6 May 2013 22:43:24 +0200	[thread overview]
Message-ID: <1367873011-7402-5-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1367873011-7402-1-git-send-email-afaerber@suse.de>

From: Eduardo Habkost <ehabkost@redhat.com>

This field will contain the feature bits that were filtered out because
of missing host support.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 target-i386/cpu-qom.h | 3 +++
 target-i386/cpu.c     | 9 ++++++---
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/target-i386/cpu-qom.h b/target-i386/cpu-qom.h
index f890f1c..849cedf 100644
--- a/target-i386/cpu-qom.h
+++ b/target-i386/cpu-qom.h
@@ -65,6 +65,9 @@ typedef struct X86CPU {
     /*< public >*/
 
     CPUX86State env;
+
+    /* Features that were filtered out because of missing host capabilities */
+    uint32_t filtered_features[FEATURE_WORDS];
 } X86CPU;
 
 static inline X86CPU *x86_env_get_cpu(CPUX86State *env)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 3857514..38793bc 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1698,9 +1698,12 @@ static void filter_features_for_kvm(X86CPU *cpu)
 
     for (w = 0; w < FEATURE_WORDS; w++) {
         FeatureWordInfo *wi = &feature_word_info[w];
-        env->features[w] &= kvm_arch_get_supported_cpuid(s, wi->cpuid_eax,
-                                                            wi->cpuid_ecx,
-                                                            wi->cpuid_reg);
+        uint32_t host_feat = kvm_arch_get_supported_cpuid(s, wi->cpuid_eax,
+                                                             wi->cpuid_ecx,
+                                                             wi->cpuid_reg);
+        uint32_t requested_features = env->features[w];
+        env->features[w] &= host_feat;
+        cpu->filtered_features[w] = requested_features & ~env->features[w];
     }
 }
 #endif
-- 
1.8.1.4

  parent reply	other threads:[~2013-05-06 20:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-06 20:43 [Qemu-devel] [PULL for-1.5 00/11] QOM CPUState patch queue 2013-05-06 Andreas Färber
2013-05-06 20:43 ` [Qemu-devel] [PULL 01/11] target-i386: Add ECX information to FeatureWordInfo Andreas Färber
2013-05-06 20:43 ` [Qemu-devel] [PULL 02/11] target-i386: Use FeatureWord loop on filter_features_for_kvm() Andreas Färber
2013-05-06 20:43 ` [Qemu-devel] [PULL 03/11] target-i386: Add "feature-words" property to X86CPU Andreas Färber
2013-05-06 20:43 ` Andreas Färber [this message]
2013-05-06 20:43 ` [Qemu-devel] [PULL 05/11] target-i386: Add "filtered-features" " Andreas Färber
2013-05-06 20:43 ` [Qemu-devel] [PULL 06/11] qdev: Let qdev_prop_parse() pass through Error Andreas Färber
2013-05-06 20:43 ` [Qemu-devel] [PULL 07/11] qdev: Introduce qdev_prop_set_globals_for_type() Andreas Färber
2013-05-06 20:43 ` [Qemu-devel] [PULL 08/11] target-i386: Emulate X86CPU subclasses for global properties Andreas Färber
2013-05-06 20:43 ` [Qemu-devel] [PULL 09/11] target-i386: Change CPUID model of 486 to 8 Andreas Färber
2013-05-06 20:43 ` [Qemu-devel] [PULL 10/11] target-i386: Introduce generic CPUID feature compat function Andreas Färber
2013-05-06 20:43 ` [Qemu-devel] [PULL 11/11] target-i386: n270 can MOVBE Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367873011-7402-5-git-send-email-afaerber@suse.de \
    --to=afaerber@suse.de \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).