From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZSGO-0007Wo-Fj for qemu-devel@nongnu.org; Mon, 06 May 2013 16:44:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZSG8-0005Bj-FC for qemu-devel@nongnu.org; Mon, 06 May 2013 16:44:00 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48361 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZSG8-0005BZ-3P for qemu-devel@nongnu.org; Mon, 06 May 2013 16:43:44 -0400 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Mon, 6 May 2013 22:43:25 +0200 Message-Id: <1367873011-7402-6-git-send-email-afaerber@suse.de> In-Reply-To: <1367873011-7402-1-git-send-email-afaerber@suse.de> References: <1367873011-7402-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 05/11] target-i386: Add "filtered-features" property to X86CPU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Eduardo Habkost , =?UTF-8?q?Andreas=20F=C3=A4rber?= From: Eduardo Habkost This property will contain all the features that were removed from the CPU because they are not supported by the host. This way, libvirt or other management tools can emulate the check/enforce behavior by checking if filtered-properties is all zeroes, before starting the guest. Example output where some features were missing: $ qemu-system-x86_64 -enable-kvm -cpu Haswell,check -S \ -qmp unix:/tmp/m,server,nowait warning: host doesn't support requested feature: CPUID.01H:ECX.fma [bit= 12] warning: host doesn't support requested feature: CPUID.01H:ECX.movbe [b= it 22] warning: host doesn't support requested feature: CPUID.01H:ECX.tsc-dead= line [bit 24] warning: host doesn't support requested feature: CPUID.01H:ECX.xsave [b= it 26] warning: host doesn't support requested feature: CPUID.01H:ECX.avx [bit= 28] warning: host doesn't support requested feature: CPUID.07H:EBX.fsgsbase= [bit 0] warning: host doesn't support requested feature: CPUID.07H:EBX.bmi1 [bi= t 3] warning: host doesn't support requested feature: CPUID.07H:EBX.hle [bit= 4] warning: host doesn't support requested feature: CPUID.07H:EBX.avx2 [bi= t 5] warning: host doesn't support requested feature: CPUID.07H:EBX.smep [bi= t 7] warning: host doesn't support requested feature: CPUID.07H:EBX.bmi2 [bi= t 8] warning: host doesn't support requested feature: CPUID.07H:EBX.erms [bi= t 9] warning: host doesn't support requested feature: CPUID.07H:EBX.invpcid = [bit 10] warning: host doesn't support requested feature: CPUID.07H:EBX.rtm [bit= 11] [...] $ ./QMP/qmp --path=3D/tmp/m \ qom-get --path=3D/machine/icc-bridge/icc/child[0] \ --property=3Dfiltered-features item[0].cpuid-register: EDX item[0].cpuid-input-eax: 2147483658 item[0].features: 0 item[1].cpuid-register: EAX item[1].cpuid-input-eax: 1073741825 item[1].features: 0 item[2].cpuid-register: EDX item[2].cpuid-input-eax: 3221225473 item[2].features: 0 item[3].cpuid-register: ECX item[3].cpuid-input-eax: 2147483649 item[3].features: 0 item[4].cpuid-register: EDX item[4].cpuid-input-eax: 2147483649 item[4].features: 0 item[5].cpuid-register: EBX item[5].cpuid-input-eax: 7 item[5].features: 4025 item[5].cpuid-input-ecx: 0 item[6].cpuid-register: ECX item[6].cpuid-input-eax: 1 item[6].features: 356519936 item[7].cpuid-register: EDX item[7].cpuid-input-eax: 1 item[7].features: 0 Example output when no feature is missing: $ qemu-system-x86_64 -enable-kvm -cpu Nehalem,enforce -S \ -qmp unix:/tmp/m,server,nowait [...] $ ./QMP/qmp --path=3D/tmp/m \ qom-get --path=3D/machine/icc-bridge/icc/child[0] \ --property=3Dfiltered-features item[0].cpuid-register: EDX item[0].cpuid-input-eax: 2147483658 item[0].features: 0 item[1].cpuid-register: EAX item[1].cpuid-input-eax: 1073741825 item[1].features: 0 item[2].cpuid-register: EDX item[2].cpuid-input-eax: 3221225473 item[2].features: 0 item[3].cpuid-register: ECX item[3].cpuid-input-eax: 2147483649 item[3].features: 0 item[4].cpuid-register: EDX item[4].cpuid-input-eax: 2147483649 item[4].features: 0 item[5].cpuid-register: EBX item[5].cpuid-input-eax: 7 item[5].features: 0 item[5].cpuid-input-ecx: 0 item[6].cpuid-register: ECX item[6].cpuid-input-eax: 1 item[6].features: 0 item[7].cpuid-register: EDX item[7].cpuid-input-eax: 1 item[7].features: 0 Signed-off-by: Eduardo Habkost Reviewed-by: Eric Blake Signed-off-by: Andreas F=C3=A4rber --- target-i386/cpu.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 38793bc..eb1825b 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1418,11 +1418,11 @@ static void x86_cpuid_set_apic_id(Object *obj, Vi= sitor *v, void *opaque, cpu->env.cpuid_apic_id =3D value; } =20 +/* Generic getter for "feature-words" and "filtered-features" properties= */ static void x86_cpu_get_feature_words(Object *obj, Visitor *v, void *opa= que, const char *name, Error **errp) { - X86CPU *cpu =3D X86_CPU(obj); - CPUX86State *env =3D &cpu->env; + uint32_t *array =3D (uint32_t *)opaque; FeatureWord w; Error *err =3D NULL; X86CPUFeatureWordInfo word_infos[FEATURE_WORDS] =3D { }; @@ -1436,7 +1436,7 @@ static void x86_cpu_get_feature_words(Object *obj, = Visitor *v, void *opaque, qwi->has_cpuid_input_ecx =3D wi->cpuid_needs_ecx; qwi->cpuid_input_ecx =3D wi->cpuid_ecx; qwi->cpuid_register =3D x86_reg_info_32[wi->cpuid_reg].qapi_enum= ; - qwi->features =3D env->features[w]; + qwi->features =3D array[w]; =20 /* List will be in reverse order, but order shouldn't matter */ list_entries[w].next =3D list; @@ -2444,7 +2444,10 @@ static void x86_cpu_initfn(Object *obj) x86_cpuid_set_apic_id, NULL, NULL, NULL); object_property_add(obj, "feature-words", "X86CPUFeatureWordInfo", x86_cpu_get_feature_words, - NULL, NULL, NULL, NULL); + NULL, NULL, (void *)env->features, NULL); + object_property_add(obj, "filtered-features", "X86CPUFeatureWordInfo= ", + x86_cpu_get_feature_words, + NULL, NULL, (void *)cpu->filtered_features, NULL= ); =20 env->cpuid_apic_id =3D x86_cpu_apic_id_from_index(cs->cpu_index); =20 --=20 1.8.1.4