From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60540) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZam5-0003rJ-8G for qemu-devel@nongnu.org; Tue, 07 May 2013 01:49:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZam4-00082P-2x for qemu-devel@nongnu.org; Tue, 07 May 2013 01:49:17 -0400 Received: from mail-pb0-x22a.google.com ([2607:f8b0:400e:c01::22a]:45064) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZam3-00082J-T8 for qemu-devel@nongnu.org; Tue, 07 May 2013 01:49:16 -0400 Received: by mail-pb0-f42.google.com with SMTP id up7so151100pbc.15 for ; Mon, 06 May 2013 22:49:15 -0700 (PDT) From: Liu Ping Fan Date: Tue, 7 May 2013 13:46:56 +0800 Message-Id: <1367905622-21038-9-git-send-email-qemulist@gmail.com> In-Reply-To: <1367905622-21038-1-git-send-email-qemulist@gmail.com> References: <1367905622-21038-1-git-send-email-qemulist@gmail.com> Subject: [Qemu-devel] [PATCH v1 08/14] net: introduce lock to protect NetQueue List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mdroth , Jan Kiszka , Stefan Hajnoczi , Anthony Liguori , Paolo Bonzini From: Liu Ping Fan NetQueue will be accessed by nc and its peers at the same time, need lock to protect it. Signed-off-by: Liu Ping Fan --- net/queue.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/net/queue.c b/net/queue.c index 859d02a..2856c1d 100644 --- a/net/queue.c +++ b/net/queue.c @@ -53,6 +53,7 @@ struct NetQueue { uint32_t nq_maxlen; uint32_t nq_count; + QemuMutex lock; QTAILQ_HEAD(packets, NetPacket) packets; unsigned delivering : 1; @@ -68,6 +69,7 @@ NetQueue *qemu_new_net_queue(void *opaque) queue->nq_maxlen = 10000; queue->nq_count = 0; + qemu_mutex_init(&queue->lock); QTAILQ_INIT(&queue->packets); queue->delivering = 0; @@ -107,7 +109,9 @@ static void qemu_net_queue_append(NetQueue *queue, memcpy(packet->data, buf, size); queue->nq_count++; + qemu_mutex_lock(&queue->lock); QTAILQ_INSERT_TAIL(&queue->packets, packet, entry); + qemu_mutex_unlock(&queue->lock); } static void qemu_net_queue_append_iov(NetQueue *queue, @@ -142,7 +146,9 @@ static void qemu_net_queue_append_iov(NetQueue *queue, } queue->nq_count++; + qemu_mutex_lock(&queue->lock); QTAILQ_INSERT_TAIL(&queue->packets, packet, entry); + qemu_mutex_unlock(&queue->lock); } static ssize_t qemu_net_queue_deliver(NetQueue *queue, @@ -229,6 +235,7 @@ void qemu_net_queue_purge(NetQueue *queue, NetClientState *from) { NetPacket *packet, *next; + qemu_mutex_lock(&queue->lock); QTAILQ_FOREACH_SAFE(packet, &queue->packets, entry, next) { if (packet->sender == from) { QTAILQ_REMOVE(&queue->packets, packet, entry); @@ -236,10 +243,12 @@ void qemu_net_queue_purge(NetQueue *queue, NetClientState *from) g_free(packet); } } + qemu_mutex_unlock(&queue->lock); } bool qemu_net_queue_flush(NetQueue *queue) { + qemu_mutex_lock(&queue->lock); while (!QTAILQ_EMPTY(&queue->packets)) { NetPacket *packet; int ret; @@ -256,6 +265,7 @@ bool qemu_net_queue_flush(NetQueue *queue) if (ret == 0) { queue->nq_count++; QTAILQ_INSERT_HEAD(&queue->packets, packet, entry); + qemu_mutex_unlock(&queue->lock); return false; } @@ -265,5 +275,6 @@ bool qemu_net_queue_flush(NetQueue *queue) g_free(packet); } + qemu_mutex_unlock(&queue->lock); return true; } -- 1.7.4.4