* [Qemu-devel] [PATCH] host-libusb: Correct test for USB packet state
@ 2013-05-07 14:06 Ed Maste
2013-05-21 13:45 ` Ed Maste
0 siblings, 1 reply; 3+ messages in thread
From: Ed Maste @ 2013-05-07 14:06 UTC (permalink / raw)
To: qemu-devel; +Cc: Ed Maste
USB_RET_ASYNC is -6, so inflight was always false.
Signed-off-by: Ed Maste <emaste@freebsd.org>
---
hw/usb/host-libusb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c
index d1186b8..0af6ce3 100644
--- a/hw/usb/host-libusb.c
+++ b/hw/usb/host-libusb.c
@@ -384,7 +384,7 @@ out:
static void usb_host_req_abort(USBHostRequest *r)
{
USBHostDevice *s = r->host;
- bool inflight = (r->p && r->p->state == USB_RET_ASYNC);
+ bool inflight = (r->p && r->p->state == USB_PACKET_ASYNC);
if (inflight) {
r->p->status = USB_RET_NODEV;
--
1.7.11.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] host-libusb: Correct test for USB packet state
2013-05-07 14:06 [Qemu-devel] [PATCH] host-libusb: Correct test for USB packet state Ed Maste
@ 2013-05-21 13:45 ` Ed Maste
2013-05-28 10:50 ` Gerd Hoffmann
0 siblings, 1 reply; 3+ messages in thread
From: Ed Maste @ 2013-05-21 13:45 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
On 7 May 2013 10:06, Ed Maste <emaste@freebsd.org> wrote:
> USB_RET_ASYNC is -6, so inflight was always false.
Ping. I believe the "if (inflight)" block in usb_host_req_abort() can
never be executed in the current code.
> Signed-off-by: Ed Maste <emaste@freebsd.org>
> ---
> hw/usb/host-libusb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c
> index d1186b8..0af6ce3 100644
> --- a/hw/usb/host-libusb.c
> +++ b/hw/usb/host-libusb.c
> @@ -384,7 +384,7 @@ out:
> static void usb_host_req_abort(USBHostRequest *r)
> {
> USBHostDevice *s = r->host;
> - bool inflight = (r->p && r->p->state == USB_RET_ASYNC);
> + bool inflight = (r->p && r->p->state == USB_PACKET_ASYNC);
>
> if (inflight) {
> r->p->status = USB_RET_NODEV;
> --
> 1.7.11.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] host-libusb: Correct test for USB packet state
2013-05-21 13:45 ` Ed Maste
@ 2013-05-28 10:50 ` Gerd Hoffmann
0 siblings, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2013-05-28 10:50 UTC (permalink / raw)
To: Ed Maste; +Cc: qemu-devel
On 05/21/13 15:45, Ed Maste wrote:
> On 7 May 2013 10:06, Ed Maste <emaste@freebsd.org> wrote:
>> USB_RET_ASYNC is -6, so inflight was always false.
>
> Ping. I believe the "if (inflight)" block in usb_host_req_abort() can
> never be executed in the current code.
Patch added to usb patch queue.
thanks,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-28 10:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-07 14:06 [Qemu-devel] [PATCH] host-libusb: Correct test for USB packet state Ed Maste
2013-05-21 13:45 ` Ed Maste
2013-05-28 10:50 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).