From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ua1aR-0003X0-BX for qemu-devel@nongnu.org; Wed, 08 May 2013 06:27:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ua1aP-0002cO-V3 for qemu-devel@nongnu.org; Wed, 08 May 2013 06:27:03 -0400 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:49362) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ua1aP-0002bz-7J for qemu-devel@nongnu.org; Wed, 08 May 2013 06:27:01 -0400 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 8 May 2013 20:20:44 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 20F712CE804A for ; Wed, 8 May 2013 20:26:54 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r48AQk2321102640 for ; Wed, 8 May 2013 20:26:47 +1000 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r48AQrhC024060 for ; Wed, 8 May 2013 20:26:53 +1000 From: Wenchao Xia Date: Wed, 8 May 2013 18:25:11 +0800 Message-Id: <1368008716-9632-1-git-send-email-xiawenc@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH V5 0/5] block: make qmp_transaction extendable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@gmail.com, dietmar@proxmox.com, pbonzini@redhat.com, Wenchao Xia This serial will package backing chain snapshot code as one case, to make it possible adding more operations later. v2: Address Kevin's comments: Use the same prototype prepare, commit, rollback model in original code, commit should never fail. v3: Address Stefan's comments: 3/5, 4/5: remove *action parameter since later only BlkTransactionStates* is needed. 5/5: embbed BlkTransactionStates in ExternalSnapshotStates, *opaque is removed, related call back function format change for external snapshot. Address Kevin's comments: removed all indention in commit message. 1/5: return void for prepare() function, *errp plays the role as error checker. 5/5: mark *commit callback must exist, *rollback callback can be NULL. Align "callback =" in "const BdrvActionOps external_snapshot_ops" to the same colum. Address Eric's comments: 1/5: better commit message. 5/5: better commit message and comments in code that only one of rollback() or commit() will be called. v4: 5/5: document clean() callback will always be called if it present, declare static for global variable "actions", use array plus .instance_size to remove "switch" checking code according to caller input. v5: better commit message and comments, switch callback function name "rollback" to "abort". Wenchao Xia (5): 1 block: package preparation code in qmp_transaction() 2 block: move input parsing code in qmp_transaction() 3 block: package committing code in qmp_transaction() 4 block: package rollback code in qmp_transaction() 5 block: make all steps in qmp_transaction() as callback blockdev.c | 266 ++++++++++++++++++++++++++++++++++++++---------------------- 1 files changed, 169 insertions(+), 97 deletions(-)