From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 10/10] qemu-iotests: fix 017 018 for vmdk
Date: Wed, 8 May 2013 16:29:04 +0200 [thread overview]
Message-ID: <1368023344-29731-11-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1368023344-29731-1-git-send-email-kwolf@redhat.com>
From: Fam Zheng <famz@redhat.com>
017 and 018 use /bin/mv to move base img from t.IMGFMG to t.IMGFMT.base
after filling data, this is not enough for vmdk, when t.IMGFMT is only a
description text file who points to t-{flat,s001,f001,...}.IMGFMT as
data extent, so testing such subformats alway fails on them.
This patch use the trick of temprorily changing TEST_IMG to avoid using
/bin/mv.
Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
tests/qemu-iotests/017 | 4 +++-
tests/qemu-iotests/017.out | 2 +-
tests/qemu-iotests/018 | 4 +++-
tests/qemu-iotests/018.out | 2 +-
4 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/tests/qemu-iotests/017 b/tests/qemu-iotests/017
index 66951eb..45f2c0b 100755
--- a/tests/qemu-iotests/017
+++ b/tests/qemu-iotests/017
@@ -46,6 +46,8 @@ _supported_os Linux
TEST_OFFSETS="0 4294967296"
+TEST_IMG_SAVE=$TEST_IMG
+TEST_IMG=$TEST_IMG.base
_make_test_img 6G
echo "Filling base image"
@@ -63,7 +65,7 @@ _check_test_img
echo "Creating test image with backing file"
echo
-mv $TEST_IMG $TEST_IMG.base
+TEST_IMG=$TEST_IMG_SAVE
_make_test_img -b $TEST_IMG.base 6G
echo "Filling test image"
diff --git a/tests/qemu-iotests/017.out b/tests/qemu-iotests/017.out
index a861e58..df34ee7 100644
--- a/tests/qemu-iotests/017.out
+++ b/tests/qemu-iotests/017.out
@@ -1,5 +1,5 @@
QA output created by 017
-Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=6442450944
+Formatting 'TEST_DIR/t.IMGFMT.base', fmt=IMGFMT size=6442450944
Filling base image
=== IO: pattern 0
diff --git a/tests/qemu-iotests/018 b/tests/qemu-iotests/018
index bd2db78..453ce61 100755
--- a/tests/qemu-iotests/018
+++ b/tests/qemu-iotests/018
@@ -46,6 +46,8 @@ _supported_os Linux
TEST_OFFSETS="0 4294967296"
+TEST_IMG_SAVE=$TEST_IMG
+TEST_IMG=$TEST_IMG.base
_make_test_img 6G
echo "Filling base image"
@@ -63,7 +65,7 @@ _check_test_img
echo "Creating test image with backing file"
echo
-mv $TEST_IMG $TEST_IMG.base
+TEST_IMG=$TEST_IMG_SAVE
_make_test_img -b $TEST_IMG.base 6G
echo "Filling test image"
diff --git a/tests/qemu-iotests/018.out b/tests/qemu-iotests/018.out
index 6bbd815..3ddb8d8 100644
--- a/tests/qemu-iotests/018.out
+++ b/tests/qemu-iotests/018.out
@@ -1,5 +1,5 @@
QA output created by 018
-Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=6442450944
+Formatting 'TEST_DIR/t.IMGFMT.base', fmt=IMGFMT size=6442450944
Filling base image
=== IO: pattern 0
--
1.8.1.4
prev parent reply other threads:[~2013-05-08 14:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 14:28 [Qemu-devel] [PULL 1.5 00/10] Block patches for 1.5.0-rc1 Kevin Wolf
2013-05-08 14:28 ` [Qemu-devel] [PATCH 01/10] ahci: Don't allow creating slave drives Kevin Wolf
2013-05-08 14:28 ` [Qemu-devel] [PATCH 02/10] de_DE.po: Add missing leading spaces Kevin Wolf
2013-05-08 14:28 ` [Qemu-devel] [PATCH 03/10] ide: Reset BMIDEA bit when the bus master is stopped Kevin Wolf
2013-05-08 14:28 ` [Qemu-devel] [PATCH 04/10] libqos/pci: Enable bus mastering Kevin Wolf
2013-05-08 14:28 ` [Qemu-devel] [PATCH 05/10] qtest: Add IDE test case Kevin Wolf
2013-05-08 14:29 ` [Qemu-devel] [PATCH 06/10] qtest/ide-test: Add simple DMA read/write " Kevin Wolf
2013-05-08 14:29 ` [Qemu-devel] [PATCH 07/10] qtest/ide-test: Test short and long PRDTs Kevin Wolf
2013-05-08 14:29 ` [Qemu-devel] [PATCH 08/10] qemu-iotests: exclude vmdk for test 042 Kevin Wolf
2013-05-08 14:29 ` [Qemu-devel] [PATCH 09/10] qemu-iotests: exclude vmdk and qcow from 043 Kevin Wolf
2013-05-08 14:29 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368023344-29731-11-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).