From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ua92u-0007ba-MB for qemu-devel@nongnu.org; Wed, 08 May 2013 14:24:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ua92s-00047g-2N for qemu-devel@nongnu.org; Wed, 08 May 2013 14:24:56 -0400 From: Alexander Graf Date: Wed, 8 May 2013 20:24:47 +0200 Message-Id: <1368037488-11572-2-git-send-email-agraf@suse.de> In-Reply-To: <1368037488-11572-1-git-send-email-agraf@suse.de> References: <1368037488-11572-1-git-send-email-agraf@suse.de> Subject: [Qemu-devel] [PATCH 1/2] PPC: Fix rldcl List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-ppc@nongnu.org Cc: Blue Swirl , Aurelien Jarno , qemu-devel@nongnu.org, Anthony Liguori The implementation for rldcl tried to always fetch its parameters from the opcode, even though the opcode was already passed in in decoded and different forms. Use the parameters instead, fixing rldcl. Reported-by: Torbjorn Granlund Reviewed-by: Aurelien Jarno Signed-off-by: Alexander Graf --- target-ppc/translate.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 0886f4d..a018616 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -1733,8 +1733,6 @@ static inline void gen_rldnm(DisasContext *ctx, uint32_t mb, uint32_t me) { TCGv t0; - mb = MB(ctx->opcode); - me = ME(ctx->opcode); t0 = tcg_temp_new(); tcg_gen_andi_tl(t0, cpu_gpr[rB(ctx->opcode)], 0x3f); tcg_gen_rotl_tl(t0, cpu_gpr[rS(ctx->opcode)], t0); -- 1.6.0.2