From: Jordan Justen <jordan.l.justen@intel.com>
To: qemu-devel@nongnu.org
Cc: Jordan Justen <jordan.l.justen@intel.com>
Subject: [Qemu-devel] [PATCH v5 5/5] pc_sysfw: change rom_only default to 0
Date: Wed, 8 May 2013 15:44:42 -0700 [thread overview]
Message-ID: <1368053082-15710-6-git-send-email-jordan.l.justen@intel.com> (raw)
In-Reply-To: <1368053082-15710-1-git-send-email-jordan.l.justen@intel.com>
Now KVM can support a flash memory. This feature depends on
KVM_CAP_READONLY_MEM, which was introduced in Linux 3.7.
Flash memory will only be enabled if a pflash device is
created. (For example, by using the -pflash command line
parameter.)
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
---
hw/block/pc_sysfw.c | 2 +-
include/hw/i386/pc.h | 4 ----
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/hw/block/pc_sysfw.c b/hw/block/pc_sysfw.c
index d8a499d..259fe5d 100644
--- a/hw/block/pc_sysfw.c
+++ b/hw/block/pc_sysfw.c
@@ -273,7 +273,7 @@ void pc_system_firmware_init(MemoryRegion *rom_memory)
static Property pcsysfw_properties[] = {
DEFINE_PROP_UINT8("isapc_ram_fw", PcSysFwDevice, isapc_ram_fw, 0),
- DEFINE_PROP_UINT8("rom_only", PcSysFwDevice, rom_only, 1),
+ DEFINE_PROP_UINT8("rom_only", PcSysFwDevice, rom_only, 0),
DEFINE_PROP_END_OF_LIST(),
};
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 417afe4..932de04 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -239,10 +239,6 @@ int e820_add_entry(uint64_t, uint64_t, uint32_t);
.property = "romfile",\
.value = "pxe-virtio.rom",\
},{\
- .driver = "pc-sysfw",\
- .property = "rom_only",\
- .value = stringify(0),\
- },{\
.driver = "486-" TYPE_X86_CPU,\
.property = "model",\
.value = stringify(0),\
--
1.7.10.4
next prev parent reply other threads:[~2013-05-08 22:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 22:44 [Qemu-devel] [PATCH v5 0/5] KVM flash memory support Jordan Justen
2013-05-08 22:44 ` [Qemu-devel] [PATCH v5 1/5] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS) Jordan Justen
2013-05-08 22:44 ` [Qemu-devel] [PATCH v5 2/5] kvm: add kvm_readonly_mem_enabled Jordan Justen
2013-05-08 22:44 ` [Qemu-devel] [PATCH v5 3/5] kvm: support using KVM_MEM_READONLY flag for regions Jordan Justen
2013-05-08 22:44 ` [Qemu-devel] [PATCH v5 4/5] pc_sysfw: allow flash (-pflash) memory to be used with KVM Jordan Justen
2013-05-08 22:44 ` Jordan Justen [this message]
2013-05-09 6:27 ` [Qemu-devel] [PATCH v5 0/5] KVM flash memory support Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368053082-15710-6-git-send-email-jordan.l.justen@intel.com \
--to=jordan.l.justen@intel.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).