qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: akong@redhat.com, lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH 2/8] qapi: qapi-visit.py, fix list handling for union types
Date: Wed,  8 May 2013 18:33:51 -0500	[thread overview]
Message-ID: <1368056037-16350-3-git-send-email-mdroth@linux.vnet.ibm.com> (raw)
In-Reply-To: <1368056037-16350-1-git-send-email-mdroth@linux.vnet.ibm.com>

Currently we assume non-list types when generating visitor routines for
union types. This is broken, since values like ['Type'] need to mapped
to 'TypeList'.

We already have a type_name() function to handle this that we use for
generating struct visitors, so use that here as well.

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
 scripts/qapi-visit.py |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py
index a276540..4c4de4b 100644
--- a/scripts/qapi-visit.py
+++ b/scripts/qapi-visit.py
@@ -174,7 +174,7 @@ void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const char *name, Error **
 ''',
                 abbrev = de_camel_case(name).upper(),
                 enum = c_fun(de_camel_case(key),False).upper(),
-                c_type=members[key],
+                c_type=type_name(members[key]),
                 c_name=c_fun(key))
 
     ret += mcgen('''
-- 
1.7.9.5

  parent reply	other threads:[~2013-05-08 23:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-08 23:33 [Qemu-devel] [PATCH 0/8] qapi: add support for lists of native types Michael Roth
2013-05-08 23:33 ` [Qemu-devel] [PATCH 1/8] qapi: qapi-types.py, native list support Michael Roth
2013-05-08 23:33 ` Michael Roth [this message]
2013-05-08 23:33 ` [Qemu-devel] [PATCH 3/8] qapi: qapi-visit.py, " Michael Roth
2013-05-08 23:33 ` [Qemu-devel] [PATCH 4/8] qapi: enable generation of native list code Michael Roth
2013-05-08 23:33 ` [Qemu-devel] [PATCH 5/8] qapi: fix leak in unit tests Michael Roth
2013-05-08 23:33 ` [Qemu-devel] [PATCH 6/8] qapi: add native list coverage for visitor serialization tests Michael Roth
2013-05-09 12:31   ` Laszlo Ersek
2013-05-09 13:32     ` mdroth
2013-05-08 23:33 ` [Qemu-devel] [PATCH 7/8] qapi: add native list coverage for QMP output visitor tests Michael Roth
2013-05-08 23:33 ` [Qemu-devel] [PATCH 8/8] qapi: add native list coverage for QMP input " Michael Roth
2013-05-09 13:31 ` [Qemu-devel] [PATCH 0/8] qapi: add support for lists of native types Laszlo Ersek
2013-05-09 13:49   ` mdroth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1368056037-16350-3-git-send-email-mdroth@linux.vnet.ibm.com \
    --to=mdroth@linux.vnet.ibm.com \
    --cc=akong@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).