From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaEuP-00064Y-2P for qemu-devel@nongnu.org; Wed, 08 May 2013 20:40:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UaEuO-0000g5-5e for qemu-devel@nongnu.org; Wed, 08 May 2013 20:40:33 -0400 Received: from mail-da0-x236.google.com ([2607:f8b0:400e:c00::236]:55156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaEuN-0000fz-St for qemu-devel@nongnu.org; Wed, 08 May 2013 20:40:32 -0400 Received: by mail-da0-f54.google.com with SMTP id u36so1281783dak.13 for ; Wed, 08 May 2013 17:40:30 -0700 (PDT) From: Liu Ping Fan Date: Thu, 9 May 2013 08:40:21 +0800 Message-Id: <1368060022-16911-1-git-send-email-qemulist@gmail.com> Subject: [Qemu-devel] [PATCH 1/2] Vring: vring's listener's priority should higher than kvm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Anthony Liguori , "Michael S. Tsirkin" , Jan Kiszka , Stefan Hajnoczi , Paolo Bonzini From: Liu Ping Fan Hosts threads which handle vring should have high MemoryListener priority than kvm. For currently code, take the following scenario: kvm_region_add() run earlier before vhost_region_add(), then in guest, vring's desc[i] can refer to addressX in the new region known by guest. But vhost does not know this new region yet, and the vring handler will fail. Signed-off-by: Liu Ping Fan --- hw/virtio/dataplane/hostmem.c | 2 +- hw/virtio/vhost.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio/dataplane/hostmem.c b/hw/virtio/dataplane/hostmem.c index 37292ff..67cbce1 100644 --- a/hw/virtio/dataplane/hostmem.c +++ b/hw/virtio/dataplane/hostmem.c @@ -158,7 +158,7 @@ void hostmem_init(HostMem *hostmem) .eventfd_del = hostmem_listener_eventfd_dummy, .coalesced_mmio_add = hostmem_listener_coalesced_mmio_dummy, .coalesced_mmio_del = hostmem_listener_coalesced_mmio_dummy, - .priority = 10, + .priority = 9, }; memory_listener_register(&hostmem->listener, &address_space_memory); diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index fbabf99..91c313b 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -856,7 +856,7 @@ int vhost_dev_init(struct vhost_dev *hdev, int devfd, const char *devpath, .log_global_stop = vhost_log_global_stop, .eventfd_add = vhost_eventfd_add, .eventfd_del = vhost_eventfd_del, - .priority = 10 + .priority = 9 }; hdev->mem = g_malloc0(offsetof(struct vhost_memory, regions)); hdev->n_mem_sections = 0; -- 1.7.4.4