[Qemu-devel] [PULL for-1.5] spice: bugfix queue

[Qemu-devel] [PULL for-1.5] spice: bugfix queue

[Gerd Hoffmann]

  Hi,

Tiny spice patch queue, featuring a single qxl bugfix.

please pull,
  Gerd

The following changes since commit 47ec15cdd44877e553ed0bd0a16aea8a295dad62:

  Update version for 1.5.0-rc1 (2013-05-08 15:54:47 -0500)

are available in the git repository at:

  git://anongit.freedesktop.org/spice/qemu spice.v70

for you to fetch changes up to 0a2b5e3a7899b40d05d7c6c1c41eb4e64dd2ed4b:

  qxl: Call spice_qxl_driver_unload from qxl_enter_vga_mode (2013-05-09 11:46:53 +0200)

----------------------------------------------------------------
Hans de Goede (1):
      qxl: Call spice_qxl_driver_unload from qxl_enter_vga_mode

 hw/display/qxl.c |    3 +++
 1 file changed, 3 insertions(+)

[Qemu-devel] [PATCH] qxl: Call spice_qxl_driver_unload from qxl_enter_vga_mode

[Gerd Hoffmann]

From: Hans de Goede <hdegoede@redhat.com>

With a SPICE_DISPLAY_CAP_MONITORS_CONFIG capable client, the client needs to
know what part of the primary to use for each monitor. If the guest driver
does not support this, the server sends messages to the client for a
single monitor spanning the entire primary.

As soon as the guest calls spice_qxl_monitors_config_async once, the server
sets the red_worker driver_has_monitors_config flag and stops doing this.

This is a problem when the driver gets unloaded, for example after a reboot
or when switching to a text vc with usermode mode-setting under Linux.

To reproduce this start a multi-mon capable Linux guest which uses
usermode mode-setting and then once X has started switch to a text vc. Note
how the client window does not only not resize, if you try to resize it
manually you always keep blackborders since the aspect is wrong.

This patch calls a new spice-server method called spice_qxl_driver_unload
which clears the driver_has_monitors_config flag inside the server, thereby
fixing this.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/display/qxl.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/display/qxl.c b/hw/display/qxl.c
index 2d49e9a..c475cb1 100644
--- a/hw/display/qxl.c
+++ b/hw/display/qxl.c
@@ -1077,6 +1077,9 @@ static void qxl_enter_vga_mode(PCIQXLDevice *d)
         return;
     }
     trace_qxl_enter_vga_mode(d->id);
+#if SPICE_SERVER_VERSION >= 0x000c03 /* release 0.12.3 */
+    spice_qxl_driver_unload(&d->ssd.qxl);
+#endif
     qemu_spice_create_host_primary(&d->ssd);
     d->mode = QXL_MODE_VGA;
     vga_dirty_log_start(&d->vga);
-- 
1.7.9.7

Re: [Qemu-devel] [PULL for-1.5] spice: bugfix queue

[Anthony Liguori]

Pulled.  Thanks.

Regards,

Anthony Liguori