From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaUpa-0006Y8-1P for qemu-devel@nongnu.org; Thu, 09 May 2013 13:40:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UaUpT-0001dW-C5 for qemu-devel@nongnu.org; Thu, 09 May 2013 13:40:37 -0400 Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:35947) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaUpT-0001dF-5e for qemu-devel@nongnu.org; Thu, 09 May 2013 13:40:31 -0400 From: Aurelien Jarno Date: Thu, 9 May 2013 19:40:27 +0200 Message-Id: <1368121227-10885-1-git-send-email-aurelien@aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH for 1.5] target-i386 ROR r8/r16 imm instruction fix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aurelien Jarno , Richard Henderson Fix EFLAGS corruption by ROR r8/r16 imm instruction located at the end of the TB, similarly to commit 089305ac for the non-immediate case. Reported-by: Hervé Poussineau Cc: Richard Henderson Signed-off-by: Aurelien Jarno --- target-i386/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-i386/translate.c b/target-i386/translate.c index 524a0b4..0aeccdb 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -1871,6 +1871,7 @@ static void gen_rot_rm_im(DisasContext *s, int ot, int op1, int op2, if (is_right) { tcg_gen_shri_tl(cpu_cc_src2, cpu_T[0], mask - 1); tcg_gen_shri_tl(cpu_cc_dst, cpu_T[0], mask); + tcg_gen_andi_tl(cpu_cc_dst, cpu_cc_dst, 1); } else { tcg_gen_shri_tl(cpu_cc_src2, cpu_T[0], mask); tcg_gen_andi_tl(cpu_cc_dst, cpu_T[0], 1); -- 1.7.10.4