From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaczT-0001XX-N5 for qemu-devel@nongnu.org; Thu, 09 May 2013 22:23:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UaczS-0007YA-HL for qemu-devel@nongnu.org; Thu, 09 May 2013 22:23:23 -0400 Received: from mail-ia0-x22b.google.com ([2607:f8b0:4001:c02::22b]:34013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaczS-0007Y5-Bg for qemu-devel@nongnu.org; Thu, 09 May 2013 22:23:22 -0400 Received: by mail-ia0-f171.google.com with SMTP id r13so4066449iar.30 for ; Thu, 09 May 2013 19:23:21 -0700 (PDT) Sender: fluxion From: Michael Roth Date: Thu, 9 May 2013 21:20:54 -0500 Message-Id: <1368152462-13219-3-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1368152462-13219-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1368152462-13219-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 02/10] qapi: qapi-visit.py, fix list handling for union types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: akong@redhat.com, lersek@redhat.com, lcapitulino@redhat.com Currently we assume non-list types when generating visitor routines for union types. This is broken, since values like ['Type'] need to mapped to 'TypeList'. We already have a type_name() function to handle this that we use for generating struct visitors, so use that here as well. Signed-off-by: Michael Roth --- scripts/qapi-visit.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py index a276540..4c4de4b 100644 --- a/scripts/qapi-visit.py +++ b/scripts/qapi-visit.py @@ -174,7 +174,7 @@ void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const char *name, Error ** ''', abbrev = de_camel_case(name).upper(), enum = c_fun(de_camel_case(key),False).upper(), - c_type=members[key], + c_type=type_name(members[key]), c_name=c_fun(key)) ret += mcgen(''' -- 1.7.9.5