From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaooO-0007hQ-Re for qemu-devel@nongnu.org; Fri, 10 May 2013 11:00:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UaooJ-0007oQ-JX for qemu-devel@nongnu.org; Fri, 10 May 2013 11:00:44 -0400 Received: from mail-lb0-f181.google.com ([209.85.217.181]:43136) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaooJ-0007o0-Bw for qemu-devel@nongnu.org; Fri, 10 May 2013 11:00:39 -0400 Received: by mail-lb0-f181.google.com with SMTP id w10so4243386lbi.26 for ; Fri, 10 May 2013 08:00:37 -0700 (PDT) From: Igor Mitsyanko Date: Fri, 10 May 2013 18:59:45 +0400 Message-Id: <1368197985-44608-1-git-send-email-i.mitsyanko@gmail.com> Subject: [Qemu-devel] [PATCH] ui/gtk.c: do not use gdk_display_warp_pointer when GTK ver >3.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: i.mitsyanko@gmail.com, aliguori@us.ibm.com, kraxel@redhat.com Commit 9697f5d2d38e5dd1e64e8e0d64436e6d44e7b1fe "gtk: custom cursor support" introduced unconditional usage of gdk_display_warp_pointer(). This function is marked as deprecated since GTK-3.0, and triggers warning (error with -Werror) during compilation. Conditionally change gdk_display_warp_pointer() method usage to gdk_device_warp usage, as suggested by compiler. Signed-off-by: Igor Mitsyanko --- ui/gtk.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/ui/gtk.c b/ui/gtk.c index e12f228..841f912 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -331,6 +331,24 @@ static void gd_refresh(DisplayChangeListener *dcl) graphic_hw_update(dcl->con); } +#if GTK_CHECK_VERSION(3, 0, 0) +static void gd_mouse_set(DisplayChangeListener *dcl, + int x, int y, int visible) +{ + GtkDisplayState *s = container_of(dcl, GtkDisplayState, dcl); + GdkDisplay *dpy; + GdkDeviceManager *mgr; + gint x_root, y_root; + + dpy = gtk_widget_get_display(s->drawing_area); + mgr = gdk_display_get_device_manager(dpy); + gdk_window_get_root_coords(gtk_widget_get_window(s->drawing_area), + x, y, &x_root, &y_root); + gdk_device_warp(gdk_device_manager_get_client_pointer(mgr), + gtk_widget_get_screen(s->drawing_area), + x, y); +} +#else static void gd_mouse_set(DisplayChangeListener *dcl, int x, int y, int visible) { @@ -343,6 +361,7 @@ static void gd_mouse_set(DisplayChangeListener *dcl, gtk_widget_get_screen(s->drawing_area), x_root, y_root); } +#endif static void gd_cursor_define(DisplayChangeListener *dcl, QEMUCursor *c) -- 1.8.1.4