* [Qemu-devel] [PATCH] osdep.h: include sys/types.h for ssize_t definition
@ 2013-05-10 15:16 Igor Mitsyanko
2013-05-10 15:24 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Igor Mitsyanko @ 2013-05-10 15:16 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, pbonzini, aliguori, Igor Mitsyanko
This fixes build for mingw32
Signed-off-by: Igor Mitsyanko <i.mitsyanko@gmail.com>
---
include/qemu/osdep.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
index 42545bc..17946a3 100644
--- a/include/qemu/osdep.h
+++ b/include/qemu/osdep.h
@@ -163,6 +163,8 @@ int qemu_create_pidfile(const char *filename);
int qemu_get_thread_id(void);
#ifndef CONFIG_IOVEC
+#include <sys/types.h>
+
struct iovec {
void *iov_base;
size_t iov_len;
--
1.8.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] osdep.h: include sys/types.h for ssize_t definition
2013-05-10 15:16 [Qemu-devel] [PATCH] osdep.h: include sys/types.h for ssize_t definition Igor Mitsyanko
@ 2013-05-10 15:24 ` Peter Maydell
2013-05-10 15:40 ` Igor Mitsyanko
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2013-05-10 15:24 UTC (permalink / raw)
To: Igor Mitsyanko; +Cc: qemu-trivial, pbonzini, aliguori, qemu-devel
On 10 May 2013 16:16, Igor Mitsyanko <i.mitsyanko@gmail.com> wrote:
> This fixes build for mingw32
>
> Signed-off-by: Igor Mitsyanko <i.mitsyanko@gmail.com>
> ---
> include/qemu/osdep.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
> index 42545bc..17946a3 100644
> --- a/include/qemu/osdep.h
> +++ b/include/qemu/osdep.h
> @@ -163,6 +163,8 @@ int qemu_create_pidfile(const char *filename);
> int qemu_get_thread_id(void);
>
> #ifndef CONFIG_IOVEC
> +#include <sys/types.h>
> +
This is quite a long way down to have a system #include.
Can we just take the existing include of sys/types.h at
the top of the file out of its current #ifdef __OpenBSD__
guard ?
(http://hacks.owlfolio.org/header-survey/ has a full row
of greens for sys/types.h so this should be safe.)
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] osdep.h: include sys/types.h for ssize_t definition
2013-05-10 15:24 ` Peter Maydell
@ 2013-05-10 15:40 ` Igor Mitsyanko
0 siblings, 0 replies; 3+ messages in thread
From: Igor Mitsyanko @ 2013-05-10 15:40 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, pbonzini, aliguori, qemu-devel
On 05/10/2013 07:24 PM, Peter Maydell wrote:
> On 10 May 2013 16:16, Igor Mitsyanko <i.mitsyanko@gmail.com> wrote:
>> This fixes build for mingw32
>>
>> Signed-off-by: Igor Mitsyanko <i.mitsyanko@gmail.com>
>> ---
>> include/qemu/osdep.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
>> index 42545bc..17946a3 100644
>> --- a/include/qemu/osdep.h
>> +++ b/include/qemu/osdep.h
>> @@ -163,6 +163,8 @@ int qemu_create_pidfile(const char *filename);
>> int qemu_get_thread_id(void);
>>
>> #ifndef CONFIG_IOVEC
>> +#include <sys/types.h>
>> +
> This is quite a long way down to have a system #include.
>
> Can we just take the existing include of sys/types.h at
> the top of the file out of its current #ifdef __OpenBSD__
> guard ?
>
> (http://hacks.owlfolio.org/header-survey/ has a full row
> of greens for sys/types.h so this should be safe.)
>
> thanks
> -- PMM
Nice link.
Long way, yes, but there's "#include <sys/uio.h>" even further down in
this file. But I guess taking existing sys/types.h is still better, I'll
resend it.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-10 15:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-10 15:16 [Qemu-devel] [PATCH] osdep.h: include sys/types.h for ssize_t definition Igor Mitsyanko
2013-05-10 15:24 ` Peter Maydell
2013-05-10 15:40 ` Igor Mitsyanko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).