qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: akong@redhat.com, lersek@redhat.com, lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH v3 00/11] qapi: add support for lists of native types
Date: Fri, 10 May 2013 17:45:59 -0500	[thread overview]
Message-ID: <1368225970-28506-1-git-send-email-mdroth@linux.vnet.ibm.com> (raw)

These patches apply on top of qemu.git master, and can also be obtained from:
git://github.com/mdroth/qemu.git qapi-native-lists

Sending this now since a number of series have popped up in the past that
wanted this, and Amos has some pending patches (query-mac-tables) that rely
on this as well.

These patches add support for specifying lists of native qapi types
(int/bool/str/number/int8/uint8/etc) like so:

  { 'type': 'foo',
    'data': { 'bar': ['int'] }}

for a 'bar' field that is a list of type 'int',

  { 'type': 'foo2',
    'data': { 'bar2': ['str'] }}

for a 'bar2' field that is a list of type 'str', and so on.

This uses linked list types for the native C representations, just as we do
for complex schema-defined types. In the future we may add schema annotations
of some sort to specify a more natural/efficient array type for the C
representations, but this should serve the majority of uses-cases for now.

v2->v3:
 * added native list support for fixed-width integer types (Amos)
 * added fixed-width integer list coverage to serialization,
   QMPOutputVisitor, and QmpInputVisitor unit tests
 * added unit test to QmpInputVisitor to test new overflow handling when
   integers types are expected (Eric)
 * clarified terminology/documentation in json parser fix (Laszlo)
 * fixed whitespace/newlines in code generator output (Luiz)

v1->v2:
 * fixed do-nothing float tests in pre-existing code and updated new
   unit tests accordingly (Laszlo)
 * added a fix for a bug in json parser that was exposed by above change
 * fixed misuse of string format parameters for float testing (Laszlo)
 * fixed extra characters in comment (Laszlo)
 * removed unused variant from UserDefNativeListUnion QAPI type

 Makefile                           |    6 +-
 qapi-schema-test.json              |   15 ++
 qobject/json-parser.c              |   26 +-
 scripts/qapi-types.py              |   45 +++-
 scripts/qapi-visit.py              |   36 ++-
 scripts/qapi.py                    |   23 ++
 tests/test-qmp-input-visitor.c     |  358 ++++++++++++++++++++++++++
 tests/test-qmp-output-visitor.c    |  332 ++++++++++++++++++++++++
 tests/test-visitor-serialization.c |  485 +++++++++++++++++++++++++++++++++---
 9 files changed, 1274 insertions(+), 52 deletions(-)

             reply	other threads:[~2013-05-10 22:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-10 22:45 Michael Roth [this message]
2013-05-10 22:46 ` [Qemu-devel] [PATCH 01/11] qapi: qapi-types.py, native list support Michael Roth
2013-05-10 22:46 ` [Qemu-devel] [PATCH 02/11] qapi: qapi-visit.py, fix list handling for union types Michael Roth
2013-05-10 22:46 ` [Qemu-devel] [PATCH 03/11] qapi: qapi-visit.py, native list support Michael Roth
2013-05-10 22:46 ` [Qemu-devel] [PATCH 04/11] qapi: enable generation of native list code Michael Roth
2013-05-10 22:46 ` [Qemu-devel] [PATCH 05/11] qapi: fix leak in unit tests Michael Roth
2013-05-10 22:46 ` [Qemu-devel] [PATCH 06/11] json-parser: fix handling of large whole number values Michael Roth
2013-05-10 22:46 ` [Qemu-devel] [PATCH 07/11] qapi: add QMP input test for large integers Michael Roth
2013-05-10 22:46 ` [Qemu-devel] [PATCH 08/11] qapi: fix visitor serialization tests for numbers/doubles Michael Roth
2013-05-10 22:46 ` [Qemu-devel] [PATCH 09/11] qapi: add native list coverage for visitor serialization tests Michael Roth
2013-05-10 22:46 ` [Qemu-devel] [PATCH 10/11] qapi: add native list coverage for QMP output visitor tests Michael Roth
2013-05-10 22:46 ` [Qemu-devel] [PATCH 11/11] qapi: add native list coverage for QMP input " Michael Roth
2013-05-13  6:54 ` [Qemu-devel] [PATCH v3 00/11] qapi: add support for lists of native types Laszlo Ersek
2013-05-13 13:52 ` Amos Kong
2013-05-15 13:17 ` Luiz Capitulino
2013-05-15 14:32   ` mdroth
2013-05-15 15:04     ` Luiz Capitulino
2013-05-15 17:42       ` mdroth
2013-05-15 18:05         ` Luiz Capitulino
2013-05-15 19:13           ` mdroth
2013-05-16 10:38             ` Laszlo Ersek
2013-05-16 10:45               ` Peter Maydell
2013-05-17 20:06               ` mdroth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1368225970-28506-1-git-send-email-mdroth@linux.vnet.ibm.com \
    --to=mdroth@linux.vnet.ibm.com \
    --cc=akong@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=lersek@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).