From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UbfYb-0003Y8-PU for qemu-devel@nongnu.org; Sun, 12 May 2013 19:20:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UbfYZ-0005rw-GH for qemu-devel@nongnu.org; Sun, 12 May 2013 19:19:57 -0400 Received: from mail-vb0-x230.google.com ([2607:f8b0:400c:c02::230]:65031) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UbfYZ-0005rq-CU for qemu-devel@nongnu.org; Sun, 12 May 2013 19:19:55 -0400 Received: by mail-vb0-f48.google.com with SMTP id q16so4714015vbe.21 for ; Sun, 12 May 2013 16:19:54 -0700 (PDT) From: Michael Marineau Date: Sun, 12 May 2013 19:19:37 -0400 Message-Id: <1368400777-2938-1-git-send-email-mike@marineau.org> Subject: [Qemu-devel] [PATCH] Fix usage of USB_DEV_FLAG_IS_HOST flag. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Michael Marineau USB_DEV_FLAG_IS_HOST is the bit number, not value. Booting with a "Fitbit Base Station" USB dongle was triggering this assert. Signed-off-by: Michael Marineau --- hw/usb/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/core.c b/hw/usb/core.c index 15a150a..05948ca 100644 --- a/hw/usb/core.c +++ b/hw/usb/core.c @@ -410,7 +410,7 @@ void usb_handle_packet(USBDevice *dev, USBPacket *p) assert(p->ep->type != USB_ENDPOINT_XFER_ISOC); /* using async for interrupt packets breaks migration */ assert(p->ep->type != USB_ENDPOINT_XFER_INT || - (dev->flags & USB_DEV_FLAG_IS_HOST)); + (dev->flags & (1 << USB_DEV_FLAG_IS_HOST))); usb_packet_set_state(p, USB_PACKET_ASYNC); QTAILQ_INSERT_TAIL(&p->ep->queue, p, queue); } else if (p->status == USB_RET_ADD_TO_QUEUE) { -- 1.8.1.2