qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, jcody@redhat.com, Fam Zheng <famz@redhat.com>,
	stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v2 02/11] curl: change magic number to macro
Date: Tue, 14 May 2013 10:26:21 +0800	[thread overview]
Message-ID: <1368498390-20738-3-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1368498390-20738-1-git-send-email-famz@redhat.com>

String field length is duplicated in two places. Make it a macro.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 block/curl.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/block/curl.c b/block/curl.c
index 14f4552..aa78086 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -70,7 +70,8 @@ typedef struct CURLState
     size_t buf_start;
     size_t buf_off;
     size_t buf_len;
-    char range[128];
+#define CURL_RANGE_SIZE 128
+    char range[CURL_RANGE_SIZE];
     char errmsg[CURL_ERROR_SIZE];
     char in_use;
 } CURLState;
@@ -567,7 +568,7 @@ static void curl_readv_bh_cb(void *p)
     state->orig_buf = g_malloc(state->buf_len);
     state->acb[0] = acb;
 
-    snprintf(state->range, 127, "%zd-%zd", start, end);
+    snprintf(state->range, CURL_RANGE_SIZE - 1, "%zd-%zd", start, end);
     DPRINTF("CURL (AIO): Reading %d at %zd (%s)\n",
             (acb->nb_sectors * SECTOR_SIZE), start, state->range);
     curl_easy_setopt(state->curl, CURLOPT_RANGE, state->range);
-- 
1.8.1.4

  parent reply	other threads:[~2013-05-14  2:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-14  2:26 [Qemu-devel] [PATCH v2 00/11] curl: fix curl read Fam Zheng
2013-05-14  2:26 ` [Qemu-devel] [PATCH v2 01/11] curl: introduce CURLSockInfo to BDRVCURLState Fam Zheng
2013-05-14  7:59   ` Stefan Hajnoczi
2013-05-14  2:26 ` Fam Zheng [this message]
2013-05-14  8:04   ` [Qemu-devel] [PATCH v2 02/11] curl: change magic number to macro Stefan Hajnoczi
2013-05-14  2:26 ` [Qemu-devel] [PATCH v2 03/11] curl: change curl_multi_do to curl_fd_handler Fam Zheng
2013-05-14  2:26 ` [Qemu-devel] [PATCH v2 04/11] curl: fix curl_open Fam Zheng
2013-05-14  8:13   ` Stefan Hajnoczi
2013-05-14  2:26 ` [Qemu-devel] [PATCH v2 05/11] curl: add timer to BDRVCURLState Fam Zheng
2013-05-14  2:26 ` [Qemu-devel] [PATCH v2 06/11] curl: introduce CURLDataCache Fam Zheng
2013-05-14  2:26 ` [Qemu-devel] [PATCH v2 07/11] curl: make use of CURLDataCache Fam Zheng
2013-05-14  2:26 ` [Qemu-devel] [PATCH v2 08/11] curl: use list to store CURLState Fam Zheng
2013-05-14  2:26 ` [Qemu-devel] [PATCH v2 09/11] curl: release everything on curl_close Fam Zheng
2013-05-14  8:20   ` Stefan Hajnoczi
2013-05-14  2:26 ` [Qemu-devel] [PATCH v2 10/11] curl: add cache quota Fam Zheng
2013-05-14  2:26 ` [Qemu-devel] [PATCH v2 11/11] curl: introduce ssl_no_cert runtime option Fam Zheng
2013-05-14  8:22 ` [Qemu-devel] [PATCH v2 00/11] curl: fix curl read Stefan Hajnoczi
2013-05-14  8:50   ` Fam Zheng
2013-05-15  3:46   ` Fam Zheng
2013-05-15  7:56     ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1368498390-20738-3-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).