From: David Gibson <david@gibson.dropbear.id.au>
To: alex.williamson@redhat.com, pbonzini@redhat.com
Cc: aik@ozlabs.ru, David Gibson <david@gibson.dropbear.id.au>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org, mst@redhat.com
Subject: [Qemu-devel] [PATCH 09/11] memory: Add iova to IOMMUTLBEntry
Date: Tue, 14 May 2013 19:13:55 +1000 [thread overview]
Message-ID: <1368522837-20747-10-git-send-email-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <1368522837-20747-1-git-send-email-david@gibson.dropbear.id.au>
Currently, the IOMMUTLBEntry structure contains the translated address,
but not the IOVA (original untranslated address). We're going to need it
for upcoming changes, so add it in here, and populate it correctly in our
one existing iommu implementation.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
hw/ppc/spapr_iommu.c | 2 ++
include/exec/memory.h | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c
index 90469b3..07a6307 100644
--- a/hw/ppc/spapr_iommu.c
+++ b/hw/ppc/spapr_iommu.c
@@ -80,6 +80,7 @@ static IOMMUTLBEntry spapr_tce_translate_iommu(MemoryRegion *iommu, hwaddr addr)
if (tcet->bypass) {
return (IOMMUTLBEntry) {
+ .iova = 0,
.translated_addr = 0,
.addr_mask = ~(hwaddr)0,
.perm = { true, true },
@@ -102,6 +103,7 @@ static IOMMUTLBEntry spapr_tce_translate_iommu(MemoryRegion *iommu, hwaddr addr)
#endif
return (IOMMUTLBEntry) {
+ .iova = addr & ~SPAPR_TCE_PAGE_MASK,
.translated_addr = tce & ~SPAPR_TCE_PAGE_MASK,
.addr_mask = SPAPR_TCE_PAGE_MASK,
.perm = { [0] = tce & SPAPR_TCE_RO, [1] = tce & SPAPR_TCE_WO },
diff --git a/include/exec/memory.h b/include/exec/memory.h
index b97ace7..cd33439 100644
--- a/include/exec/memory.h
+++ b/include/exec/memory.h
@@ -116,7 +116,7 @@ typedef struct IOMMUTLBEntry IOMMUTLBEntry;
typedef struct MemoryRegionIOMMUOps MemoryRegionIOMMUOps;
struct IOMMUTLBEntry {
- hwaddr translated_addr;
+ hwaddr iova, translated_addr;
hwaddr addr_mask; /* 0xfff = 4k translation */
bool perm[2]; /* permissions, [0] for read, [1] for write */
};
--
1.7.10.4
next prev parent reply other threads:[~2013-05-14 9:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 9:13 [Qemu-devel] [0/11] RFC: VFIO and guest side IOMMUs, version 3 David Gibson
2013-05-14 9:13 ` [Qemu-devel] [PATCH 01/11] iommu: Fix compile error in ioapic.c David Gibson
2013-05-14 9:13 ` [Qemu-devel] [PATCH 02/11] pci: Don't del_subgregion on a non subregion David Gibson
2013-05-14 9:13 ` [Qemu-devel] [PATCH 03/11] pci: Rework PCI iommu lifetime assumptions David Gibson
2013-05-14 9:13 ` [Qemu-devel] [PATCH 04/11] pci: Use AddressSpace rather than MemoryRegion to represent PCI DMA space David Gibson
2013-05-14 9:13 ` [Qemu-devel] [PATCH 05/11] pci: Introduce helper to retrieve a PCI device's DMA address space David Gibson
2013-05-14 9:13 ` [Qemu-devel] [PATCH 06/11] memory: Sanity check that no listeners remain on a destroyed AddressSpace David Gibson
2013-05-14 9:13 ` [Qemu-devel] [PATCH 07/11] vfio: Introduce VFIO address spaces David Gibson
2013-05-14 16:53 ` Alex Williamson
2013-05-15 1:18 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2013-05-14 9:13 ` [Qemu-devel] [PATCH 08/11] vfio: Create VFIOAddressSpace objects as needed David Gibson
2013-05-14 9:13 ` David Gibson [this message]
2013-05-14 16:53 ` [Qemu-devel] [PATCH 09/11] memory: Add iova to IOMMUTLBEntry Alex Williamson
2013-05-15 3:51 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2013-05-14 21:22 ` [Qemu-devel] " Paolo Bonzini
2013-05-14 9:13 ` [Qemu-devel] [PATCH 10/11] memory: Add iommu map/unmap notifiers David Gibson
2013-05-14 17:15 ` Alex Williamson
2013-05-14 21:02 ` Paolo Bonzini
2013-05-14 21:23 ` Paolo Bonzini
2013-05-15 1:21 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2013-05-14 9:13 ` [Qemu-devel] [PATCH 11/11] vfio: Add guest side IOMMU support David Gibson
2013-05-14 9:48 ` Paolo Bonzini
2013-05-14 13:57 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2013-05-14 17:15 ` [Qemu-devel] " Alex Williamson
2013-05-15 1:33 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2013-05-15 2:51 ` Alex Williamson
2013-05-15 3:32 ` David Gibson
2013-05-16 6:53 ` David Gibson
2013-05-14 9:39 ` [Qemu-devel] [0/11] RFC: VFIO and guest side IOMMUs, version 3 Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368522837-20747-10-git-send-email-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).